Issue 11776002: Revert 175155 - PreferenceApi tests failing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11776002: Revert 175155 - PreferenceApi tests failing (Closed)

Created:
7 years, 11 months ago by rlarocque

Modified:
7 years, 11 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 175155 - PreferenceApi tests failing I suspect this is the cause of http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/10666 > "platforms" in privacy.json should be "chromeos" not "cros". > > R=asargent@chromium.org > BUG=156311 > > Review URL: https://codereview.chromium.org/11744034 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175168

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/extensions/api/privacy.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rlarocque

7 years, 11 months ago (2013-01-04 19:40:53 UTC) #2

Message was sent while issue was closed.

On 2013/01/04 19:19:44, rlarocque wrote:

The failure we saw on the buildbots looked very similar to the failed try job on
linux_chromeos for this change.  The "preference/standard" extension test
mentions privacy, which also made me suspect this change.

Expand Messages | Collapse Messages