Issue 11744034: "platforms" in privacy.json should be "chromeos" not "cros".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11744034: "platforms" in privacy.json should be "chromeos" not "cros". (Closed)

Created:
7 years, 11 months ago by not at google - send to devlin

Modified:
7 years, 11 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

"platforms" in privacy.json should be "chromeos" not "cros". R=asargent@chromium.org BUG=156311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175155

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/extensions/api/privacy.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

Hey Antony, noticed that you already reviewed a change like this before. Let's try it ...

7 years, 11 months ago (2013-01-04 15:26:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/11744034/1

7 years, 11 months ago (2013-01-04 17:56:15 UTC) #3

commit-bot: I haz the power

7 years, 11 months ago (2013-01-04 18:06:09 UTC) #4

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages