|
|
Add InitWidgets() phase for GTK infobars.
This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown. Currently, this generally happens at construction. Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase.
Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much.
BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194525
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+168 lines, -112 lines) |
Patch |
 |
M |
chrome/browser/infobars/infobar.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/alternate_nav_infobar_gtk.h
|
View
|
1
2
3
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/alternate_nav_infobar_gtk.cc
|
View
|
1
2
3
|
1 chunk |
+10 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h
|
View
|
1
2
3
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc
|
View
|
1
2
3
4
|
4 chunks |
+16 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h
|
View
|
1
2
3
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc
|
View
|
1
2
3
|
5 chunks |
+14 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/infobar_gtk.h
|
View
|
1
2
3
|
1 chunk |
+11 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/infobar_gtk.cc
|
View
|
1
2
3
4
|
11 chunks |
+69 lines, -47 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc
|
View
|
1
2
3
|
3 chunks |
+17 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/infobars/after_translate_infobar.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/infobars/before_translate_infobar.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/infobars/confirm_infobar.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/infobars/extension_infobar.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/infobars/infobar_view.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/infobars/translate_message_infobar.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|
Chromium Code Reviews
Issue
11775019:
Add InitWidgets() phase for GTK infobars. (Closed)
