Add InitWidgets() phase for GTK infobars.

chrome/browser/ui/gtk/infobars/infobar_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/infobars/infobar_gtk.h"
 
 #include "base/debug/trace_event.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 34 matching lines @@
 const int InfoBar::kMaximumArrowTargetHeight = 24;
 const int InfoBar::kDefaultArrowTargetHalfWidth = kDefaultArrowTargetHeight;
 const int InfoBar::kMaximumArrowTargetHalfWidth = 14;
 const int InfoBar::kDefaultBarTargetHeight = 36;
 
 // static
 const int InfoBarGtk::kEndOfLabelSpacing = 6;
 
 InfoBarGtk::InfoBarGtk(InfoBarService* owner, InfoBarDelegate* delegate)
     : InfoBar(owner, delegate),
-      theme_service_(GtkThemeService::GetFrom(Profile::FromBrowserContext(
-          owner->GetWebContents()->GetBrowserContext()))),
+      bg_box_(NULL),
+      hbox_(NULL),
+      theme_service_(NULL),
       signals_(new ui::GtkSignalRegistrar) {
-  DCHECK(delegate);
-  // Create |hbox_| and pad the sides.
-  hbox_ = gtk_hbox_new(FALSE, kElementPadding);
-
-  // Make the whole infor bar horizontally shrinkable.
-  gtk_widget_set_size_request(hbox_, 0, -1);
-
-  GtkWidget* padding = gtk_alignment_new(0, 0, 1, 1);
-  gtk_alignment_set_padding(GTK_ALIGNMENT(padding),
-                            0, 0, kLeftPadding, kRightPadding);
-
-  bg_box_ = gtk_event_box_new();
-  gtk_widget_set_app_paintable(bg_box_, TRUE);
-  g_signal_connect(bg_box_, "expose-event",
-                   G_CALLBACK(OnBackgroundExposeThunk), this);
-  gtk_container_add(GTK_CONTAINER(padding), hbox_);
-  gtk_container_add(GTK_CONTAINER(bg_box_), padding);
-
-  // Add the icon on the left, if any.
-  gfx::Image* icon = delegate->GetIcon();
-  if (icon) {
-    GtkWidget* image = gtk_image_new_from_pixbuf(icon->ToGdkPixbuf());
-
-    gtk_misc_set_alignment(GTK_MISC(image), 0.5, 0.5);
-
-    gtk_box_pack_start(GTK_BOX(hbox_), image, FALSE, FALSE, 0);
-  }
-
-  close_button_.reset(CustomDrawButton::CloseButtonBar(theme_service_));
-  gtk_util::CenterWidgetInHBox(hbox_, close_button_->widget(), true, 0);
-  signals_->Connect(close_button_->widget(), "clicked",
-                    G_CALLBACK(OnCloseButtonThunk), this);
-
-  widget_.Own(gtk_expanded_container_new());
-  gtk_container_add(GTK_CONTAINER(widget_.get()), bg_box_);
-  gtk_widget_set_size_request(widget_.get(), -1, 0);
-
-  g_signal_connect(widget_.get(), "child-size-request",
-                   G_CALLBACK(OnChildSizeRequestThunk),
-                   this);
-
-  registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
-                 content::Source<ThemeService>(theme_service_));
-  UpdateBorderColor();
 }
 
 InfoBarGtk::~InfoBarGtk() {
 }
 
 GtkWidget* InfoBarGtk::widget() {
   return widget_.get();
 }
 
 GdkColor InfoBarGtk::GetBorderColor() const {
+  DCHECK(theme_service_);
   return theme_service_->GetBorderColor();
 }
 
 int InfoBarGtk::AnimatingHeight() const {
   return animation().is_animating() ? bar_target_height() : 0;
 }
 
 ui::GtkSignalRegistrar* InfoBarGtk::Signals() {
   return signals_.get();
 }
 
 GtkWidget* InfoBarGtk::CreateLabel(const std::string& text) {
+  DCHECK(theme_service_);
   return theme_service_->BuildLabel(text, ui::kGdkBlack);
 }
 
 GtkWidget* InfoBarGtk::CreateLinkButton(const std::string& text) {
+  DCHECK(theme_service_);
   return theme_service_->BuildChromeLinkButton(text);
 }
 
 // static
 GtkWidget* InfoBarGtk::CreateMenuButton(const std::string& text) {
   GtkWidget* button = gtk_button_new();
   GtkWidget* former_child = gtk_bin_get_child(GTK_BIN(button));
   if (former_child)
     gtk_container_remove(GTK_CONTAINER(button), former_child);
 
@@ skipping 13 matching lines @@
 SkColor InfoBarGtk::ConvertGetColor(ColorGetter getter) {
   double r, g, b;
   (this->*getter)(delegate()->GetInfoBarType(), &r, &g, &b);
   return SkColorSetARGB(255, 255 * r, 255 * g, 255 * b);
 }
 
 void InfoBarGtk::AddLabelWithInlineLink(const string16& display_text,
                                         const string16& link_text,
                                         size_t link_offset,
                                         GCallback callback) {
+  DCHECK(hbox_);
   GtkWidget* link_button = CreateLinkButton(UTF16ToUTF8(link_text));
   gtk_util::ForceFontSizePixels(
       GTK_CHROME_LINK_BUTTON(link_button)->label, 13.4);
   DCHECK(callback);
   signals_->Connect(link_button, "clicked", callback, this);
   gtk_util::SetButtonTriggersNavigation(link_button);
 
   GtkWidget* hbox = gtk_hbox_new(FALSE, 0);
   // We want the link to be horizontally shrinkable, so that the Chrome
   // window can be resized freely even with a very long link.
@@ skipping 22 matching lines @@
 
 void InfoBarGtk::ShowMenuWithModel(GtkWidget* sender,
                                    MenuGtk::Delegate* delegate,
                                    ui::MenuModel* model) {
   menu_.reset(new MenuGtk(delegate, model));
   menu_->PopupForWidget(sender, 1, gtk_get_current_event_time());
 }
 
 void InfoBarGtk::GetTopColor(InfoBarDelegate::Type type,
                              double* r, double* g, double* b) {
+  DCHECK(theme_service_);
   SkColor color = theme_service_->UsingNativeTheme() ?
                   theme_service_->GetColor(ThemeProperties::COLOR_TOOLBAR) :
                   GetInfoBarTopColor(type);
   *r = SkColorGetR(color) / 255.0;
   *g = SkColorGetG(color) / 255.0;
   *b = SkColorGetB(color) / 255.0;
 }
 
 void InfoBarGtk::GetBottomColor(InfoBarDelegate::Type type,
                                 double* r, double* g, double* b) {
+  DCHECK(theme_service_);
   SkColor color = theme_service_->UsingNativeTheme() ?
                   theme_service_->GetColor(ThemeProperties::COLOR_TOOLBAR) :
                   GetInfoBarBottomColor(type);
   *r = SkColorGetR(color) / 255.0;
   *g = SkColorGetG(color) / 255.0;
   *b = SkColorGetB(color) / 255.0;
 }
 
 void InfoBarGtk::UpdateBorderColor() {
+  DCHECK(widget());
   gtk_widget_queue_draw(widget());
 }
 
 void InfoBarGtk::OnCloseButton(GtkWidget* button) {
   // If we're not owned, we're already closing, so don't call
   // InfoBarDismissed(), since this can lead to us double-recording dismissals.
-  if (delegate() && owned())
+  if (delegate() && owner())
     delegate()->InfoBarDismissed();
   RemoveSelf();
 }
 
 gboolean InfoBarGtk::OnBackgroundExpose(GtkWidget* sender,
                                         GdkEventExpose* event) {
   TRACE_EVENT0("ui::gtk", "InfoBarGtk::OnBackgroundExpose");
+  DCHECK(theme_service_);
 
   GtkAllocation allocation;
   gtk_widget_get_allocation(sender, &allocation);
   const int height = allocation.height;
 
   cairo_t* cr = gdk_cairo_create(gtk_widget_get_window(sender));
   gdk_cairo_rectangle(cr, &event->area);
   cairo_clip(cr);
 
   cairo_pattern_t* pattern = cairo_pattern_create_linear(0, 0, 0, height);
@@ skipping 24 matching lines @@
 
   if (container()) {
     static_cast<InfoBarContainerGtk*>(container())->
         PaintInfobarBitsOn(sender, event, this);
   }
 
   return FALSE;
 }
 
 void InfoBarGtk::PlatformSpecificShow(bool animate) {
+  if (!theme_service_)
+    InitWidgets();
+  DCHECK(bg_box_);
+
+  DCHECK(widget());
   gtk_widget_show_all(widget_.get());
   gtk_widget_set_size_request(widget_.get(), -1, bar_height());
 
   GdkWindow* gdk_window = gtk_widget_get_window(bg_box_);
   if (gdk_window)
     gdk_window_lower(gdk_window);
 }
 
 void InfoBarGtk::PlatformSpecificOnCloseSoon() {
   // We must close all menus and prevent any signals from being emitted while
   // we are animating the info bar closed.
   menu_.reset();
   signals_.reset();
 }
 
 void InfoBarGtk::PlatformSpecificOnHeightsRecalculated() {
+  DCHECK(bg_box_);
+  DCHECK(widget());
   gtk_widget_set_size_request(bg_box_, -1, bar_target_height());
   gtk_expanded_container_move(GTK_EXPANDED_CONTAINER(widget_.get()),
                               bg_box_, 0,
                               bar_height() - bar_target_height());
 
   gtk_widget_set_size_request(widget_.get(), -1, bar_height());
   gtk_widget_queue_draw(widget_.get());
 }
 
 void InfoBarGtk::Observe(int type,
                          const content::NotificationSource& source,
                          const content::NotificationDetails& details) {
+  DCHECK(widget());
   UpdateBorderColor();
 }
 
+void InfoBarGtk::InitWidgets() {
+  theme_service_ = GtkThemeService::GetFrom(Profile::FromBrowserContext(
+      owner()->GetWebContents()->GetBrowserContext()));
+
+  // Create |hbox_| and pad the sides.
+  hbox_ = gtk_hbox_new(FALSE, kElementPadding);
+
+  // Make the whole infor bar horizontally shrinkable.
+  gtk_widget_set_size_request(hbox_, 0, -1);
+
+  GtkWidget* padding = gtk_alignment_new(0, 0, 1, 1);
+  gtk_alignment_set_padding(GTK_ALIGNMENT(padding),
+                            0, 0, kLeftPadding, kRightPadding);
+
+  bg_box_ = gtk_event_box_new();
+  gtk_widget_set_app_paintable(bg_box_, TRUE);
+  g_signal_connect(bg_box_, "expose-event",
+                   G_CALLBACK(OnBackgroundExposeThunk), this);
+  gtk_container_add(GTK_CONTAINER(padding), hbox_);
+  gtk_container_add(GTK_CONTAINER(bg_box_), padding);
+
+  // Add the icon on the left, if any.
+  gfx::Image* icon = delegate()->GetIcon();
+  if (icon) {
+    GtkWidget* image = gtk_image_new_from_pixbuf(icon->ToGdkPixbuf());
+
+    gtk_misc_set_alignment(GTK_MISC(image), 0.5, 0.5);
+
+    gtk_box_pack_start(GTK_BOX(hbox_), image, FALSE, FALSE, 0);
+  }
+
+  close_button_.reset(CustomDrawButton::CloseButtonBar(theme_service_));
+  gtk_util::CenterWidgetInHBox(hbox_, close_button_->widget(), true, 0);
+  signals_->Connect(close_button_->widget(), "clicked",
+                    G_CALLBACK(OnCloseButtonThunk), this);
+
+  widget_.Own(gtk_expanded_container_new());
+  gtk_container_add(GTK_CONTAINER(widget_.get()), bg_box_);
+  gtk_widget_set_size_request(widget_.get(), -1, 0);
+
+  g_signal_connect(widget_.get(), "child-size-request",
+                   G_CALLBACK(OnChildSizeRequestThunk),
+                   this);
+
+  registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
+                 content::Source<ThemeService>(theme_service_));
+  UpdateBorderColor();
+}
+
 void InfoBarGtk::OnChildSizeRequest(GtkWidget* expanded,
                                     GtkWidget* child,
                                     GtkRequisition* requisition) {
   requisition->height = -1;
 }