cc/layer_unittest.cc - Issue 11774005: Migrate more functions from MathUtil to gfx::Transform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layer_unittest.cc

Issue 11774005: Migrate more functions from MathUtil to gfx::Transform (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Converted constructors to row-major input Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layer_unittest.cc

diff --git a/cc/layer_unittest.cc b/cc/layer_unittest.cc

index cfd62cc62faa41de57d30f842866e14082aa1a9f..c54f2826c0de23011c4a45ba1c8731f78dcfca30 100644

--- a/cc/layer_unittest.cc

+++ b/cc/layer_unittest.cc

@@ -533,12 +533,12 @@ TEST_F(LayerTest, checkPropertyChangeCausesCorrectBehavior)

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setOpacity(0.5));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setContentsOpaque(true));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setPosition(gfx::PointF(4, 9)));

- EXPECT_SET_NEEDS_COMMIT(1, testLayer->setSublayerTransform(MathUtil::createGfxTransform(0, 0, 0, 0, 0, 0)));

+ EXPECT_SET_NEEDS_COMMIT(1, testLayer->setSublayerTransform(gfx::Transform(0, 0, 0, 0, 0, 0)));

danakj 2013/01/11 04:14:12 nit: 0.0s here

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setScrollable(true));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setShouldScrollOnMainThread(true));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setNonFastScrollableRegion(gfx::Rect(1, 1, 2, 2)));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setHaveWheelEventHandlers(true));

- EXPECT_SET_NEEDS_COMMIT(1, testLayer->setTransform(MathUtil::createGfxTransform(0, 0, 0, 0, 0, 0)));

+ EXPECT_SET_NEEDS_COMMIT(1, testLayer->setTransform(gfx::Transform(0, 0, 0, 0, 0, 0)));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setDoubleSided(false));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setDebugName("Test Layer"));

EXPECT_SET_NEEDS_COMMIT(1, testLayer->setDrawCheckerboardForMissingTiles(!testLayer->drawCheckerboardForMissingTiles()));