Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1177383006: Rename all the things (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename all the things This CL moves the bulk of the SkyView code out of the |framework| directory because the |framework| directory was redundant in Dart package import declarations. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/235ee72f64f31d7e05bf1875afb692129230a3bd

Patch Set 1 #

Patch Set 2 : fix imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -6719 lines) Patch
M sky/examples/game/lib/game.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/game/lib/sprites.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/examples/game/main.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/lib/solid_color_box.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/rendering/borders.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sky/examples/rendering/interactive_flex.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/examples/rendering/justify_content.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/examples/rendering/render_paragraph.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/examples/rendering/sector_layout.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/examples/rendering/shadowed_box.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/examples/rendering/spinning_flex.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M sky/examples/rendering/touch_demo.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/examples/rendering/transform.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 1 chunk +19 lines, -19 lines 0 comments Download
M sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/examples/stocks2/lib/stock_list.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/examples/widgets/container.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/examples/widgets/hello_widgets.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/spinning_mixed.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/home.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/sdk/BUILD.gn View 4 chunks +42 lines, -42 lines 0 comments Download
A + sky/sdk/lib/app/scheduler.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/app/view.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + sky/sdk/lib/editing2/editable_string.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/editing2/editable_text.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/editing2/input.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/editing2/keyboard.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/animation/generators.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/lib/framework/app.dart View 1 chunk +0 lines, -124 lines 0 comments Download
D sky/sdk/lib/framework/editing2/editable_string.dart View 1 chunk +0 lines, -122 lines 0 comments Download
D sky/sdk/lib/framework/editing2/editable_text.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D sky/sdk/lib/framework/editing2/input.dart View 1 chunk +0 lines, -103 lines 0 comments Download
D sky/sdk/lib/framework/editing2/keyboard.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/sdk/lib/framework/painting/box_painter.dart View 1 chunk +0 lines, -271 lines 0 comments Download
D sky/sdk/lib/framework/painting/shadows.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/sdk/lib/framework/rendering/block.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D sky/sdk/lib/framework/rendering/box.dart View 1 chunk +0 lines, -1087 lines 0 comments Download
D sky/sdk/lib/framework/rendering/flex.dart View 1 chunk +0 lines, -386 lines 0 comments Download
D sky/sdk/lib/framework/rendering/object.dart View 1 chunk +0 lines, -466 lines 0 comments Download
D sky/sdk/lib/framework/rendering/paragraph.dart View 1 chunk +0 lines, -221 lines 0 comments Download
D sky/sdk/lib/framework/rendering/stack.dart View 1 chunk +0 lines, -199 lines 0 comments Download
D sky/sdk/lib/framework/scheduler.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/sdk/lib/framework/theme2/colors.dart View 1 chunk +0 lines, -253 lines 0 comments Download
D sky/sdk/lib/framework/theme2/edges.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/sdk/lib/framework/theme2/shadows.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/sdk/lib/framework/theme2/typography.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/sdk/lib/framework/theme2/view_configuration.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/sdk/lib/framework/widgets/animated_component.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D sky/sdk/lib/framework/widgets/basic.dart View 1 chunk +0 lines, -390 lines 0 comments Download
D sky/sdk/lib/framework/widgets/button_base.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/sdk/lib/framework/widgets/checkbox.dart View 1 chunk +0 lines, -135 lines 0 comments Download
D sky/sdk/lib/framework/widgets/drawer.dart View 1 chunk +0 lines, -166 lines 0 comments Download
D sky/sdk/lib/framework/widgets/drawer_header.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/sdk/lib/framework/widgets/fixed_height_scrollable.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D sky/sdk/lib/framework/widgets/floating_action_button.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/sdk/lib/framework/widgets/icon.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/sdk/lib/framework/widgets/icon_button.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/sdk/lib/framework/widgets/ink_well.dart View 1 chunk +0 lines, -109 lines 0 comments Download
D sky/sdk/lib/framework/widgets/material.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/sdk/lib/framework/widgets/menu_divider.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/sdk/lib/framework/widgets/menu_item.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/sdk/lib/framework/widgets/modal_overlay.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/sdk/lib/framework/widgets/popup_menu.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D sky/sdk/lib/framework/widgets/popup_menu_item.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/sdk/lib/framework/widgets/radio.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/sdk/lib/framework/widgets/raised_button.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/sdk/lib/framework/widgets/scaffold.dart View 1 chunk +0 lines, -217 lines 0 comments Download
D sky/sdk/lib/framework/widgets/scrollable.dart View 1 chunk +0 lines, -158 lines 0 comments Download
D sky/sdk/lib/framework/widgets/tool_bar.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/sdk/lib/framework/widgets/ui_node.dart View 1 chunk +0 lines, -858 lines 0 comments Download
A + sky/sdk/lib/painting/box_painter.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A + sky/sdk/lib/painting/shadows.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/rendering/block.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A + sky/sdk/lib/rendering/box.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/rendering/flex.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A + sky/sdk/lib/rendering/object.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/rendering/paragraph.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A + sky/sdk/lib/rendering/stack.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/theme2/colors.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/theme2/edges.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/theme2/shadows.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A + sky/sdk/lib/theme2/typography.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/theme2/view_configuration.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/animated_component.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/widgets/basic.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/button_base.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/checkbox.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/sdk/lib/widgets/drawer.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/widgets/drawer_header.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/fixed_height_scrollable.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/widgets/floating_action_button.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/widgets/icon.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/icon_button.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/widgets/ink_well.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/sdk/lib/widgets/material.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/menu_divider.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/menu_item.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/widgets/modal_overlay.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/widgets/popup_menu.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/widgets/popup_menu_item.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/radio.dart View 1 1 chunk +2 lines, -3 lines 0 comments Download
A + sky/sdk/lib/widgets/raised_button.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/widgets/scaffold.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/scrollable.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + sky/sdk/lib/widgets/tool_bar.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/widgets/ui_node.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/framework/stocks.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/raw/box_layout.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/raw/padding_deflate.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/raw/render_box.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/raw/render_flex.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/resources/display_list.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-13 16:35:27 UTC) #1
abarth-chromium
Committed patchset #2 (id:20001) manually as 235ee72f64f31d7e05bf1875afb692129230a3bd (presubmit successful).
5 years, 6 months ago (2015-06-13 16:46:59 UTC) #2
Hixie
5 years, 6 months ago (2015-06-15 17:42:59 UTC) #3
Message was sent while issue was closed.
RSLGTM. As per our discussion, a follow-up CL (not necessarily from you) should
split app/view and app/scheduler into two different directories (app/view
depends on rendering/, but app/scheduler is a peer to painting/ in the layer
cake); and should fork ./framework/animation/, ./framework/debug/ and
./framework/net/ into ./*, so that when we're done with the old webview world we
can nuke all of framework/* at once.

Powered by Google App Engine
This is Rietveld 408576698