Source/core/page/PrintContextTest.cpp - Issue 1177333002: Revert of Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PrintContextTest.cpp

Issue 1177333002: Revert of Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/PrintContextTest.cpp

diff --git a/Source/core/page/PrintContextTest.cpp b/Source/core/page/PrintContextTest.cpp

index 2f94783e7901eafe9bd5cfb1b4400264467110e2..619a7fa696898bda9279a82276ed0ded57c814dd 100644

--- a/Source/core/page/PrintContextTest.cpp

+++ b/Source/core/page/PrintContextTest.cpp

@@ -334,7 +334,7 @@

EXPECT_EQ(MockCanvas::DrawRect, operations[1].type);

EXPECT_SKRECT_EQ(350, 360, 270, 280, operations[1].rect);

- subframe->detach(FrameDetachType::Remove);

+ subframe->detach();

static_cast<SingleChildFrameLoaderClient*>(document().frame()->client())->setChild(nullptr);

document().frame()->host()->decrementSubframeCount();

}

@@ -377,7 +377,7 @@

EXPECT_EQ(MockCanvas::DrawRect, operations[2].type);

EXPECT_SKRECT_EQ(250, 260, 270, 280, operations[2].rect);

- subframe->detach(FrameDetachType::Remove);

+ subframe->detach();

static_cast<SingleChildFrameLoaderClient*>(document().frame()->client())->setChild(nullptr);

document().frame()->host()->decrementSubframeCount();

}

« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »