Source/core/page/Page.cpp - Issue 1177333002: Revert of Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.cpp

Issue 1177333002: Revert of Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Page.cpp

diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp

index ea9a53de0f937b14b67cf4a584922e6c32037e39..d6dce00d7e23641a0ce0ba76e554ed194877c732 100644

--- a/Source/core/page/Page.cpp

+++ b/Source/core/page/Page.cpp

@@ -557,7 +557,7 @@

{

RefPtrWillBeRawPtr<Frame> mainFrame = m_mainFrame;

- mainFrame->detach(FrameDetachType::Remove);

+ mainFrame->detach();

if (mainFrame->isLocalFrame()) {

toLocalFrame(mainFrame.get())->setView(nullptr);

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | Source/core/page/PrintContextTest.cpp » ('j') | no next file with comments »