mac: Fix a newly introduced history swiping bug.

mac: Fix a newly introduced history swiping bug.

Attempting to 2-finger history swipe twice in quick succession would
fail to register the second swipe ~50% of the time. The NSEvent callback with
phase=NSEventPhaseBegan non-deterministically occurs before the event has been
registered as a gesture. This was causing the history_swiper to process the
event as part of the previous gesture.

BUG=138175
TEST=In a single tab, navigate to 5 different sites. Use a trackpad to 2-finger
swipe repeatedly in the same direction. Each swipe should register as a history
swipe, and cause the page to navigate in the appropriate direction. There
should be no jankiness, and the touches should not fail to register.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241918

[erikchen, 2013-12-18 00:45:41]

please take a look

[Nico, 2013-12-18 00:53:48]

lgtm

Is it possible to test this?

https://codereview.chromium.org/117733002/diff/1/chrome/browser/renderer_host...
File
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
(right):

https://codereview.chromium.org/117733002/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm:287:
NSEventPhaseMayBegin)
if statement or body has more than 1 line, {} are mandatory

(also, filed http://llvm.org/PR18271 for this ;-) consider breaking after ||,
but since this is what clang-format produces I guess as-is is ok too)

[erikchen, 2013-12-18 01:22:07]

Add a test!

https://codereview.chromium.org/117733002/diff/1/chrome/browser/renderer_host...
File
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
(right):

https://codereview.chromium.org/117733002/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm:287:
NSEventPhaseMayBegin)
*sigh*
at least the output is deterministic. I've updated to use the reasonable syntax.

On 2013/12/18 00:53:49, Nico wrote:
> if statement or body has more than 1 line, {} are mandatory
> 
> (also, filed http://llvm.org/PR18271 for this ;-) consider breaking after ||,
> but since this is what clang-format produces I guess as-is is ok too)

[Nico, 2013-12-18 02:10:01]

slgtm

[commit-bot: I haz the power, 2013-12-18 16:25:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikchen@chromium.org/117733002/60001

[commit-bot: I haz the power, 2013-12-19 03:18:30]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-12-19 18:08:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikchen@chromium.org/117733002/60001

[commit-bot: I haz the power, 2013-12-19 19:40:50]

Change committed as 241918