Allow embedders to provide a custom view for popup (select box) widgets,

content/browser/web_contents/web_contents_view_android.cc

Index: content/browser/web_contents/web_contents_view_android.cc
===================================================================
--- content/browser/web_contents/web_contents_view_android.cc	(revision 175506)
+++ content/browser/web_contents/web_contents_view_android.cc	(working copy)
@@ -80,6 +80,11 @@
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewAndroid::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);

[Avi (use Gerrit), 2013/01/08 16:46:47]

In this and other platform files, why doesn't

return CreateViewForWidget(render_widget_host);

work? Why do you need to specify the routing of the call through the
RenderWidgetHostViewPort interface?

[rosca, 2013/01/08 19:34:29]

RenderWidgetHostView[Port]::CreateViewForWidget is the static creator for
platform specific RenderWidgetHostView*. 

WebContentsView::CreateViewForWidget is part of content API and it is used for
creating the main web page for curent web contents, its implementation usually
includes (besides widget creation) some web page specific initialisations and it
changes the WebContentsView's state with newly created web page. This is more
obvious in the win/mac implementation of WebContentsView::CreateViewForWidget.

WebContentsView[Platform]::CreateViewForWidget (for other platforms than
android) also uses RenderWidgetHostView[Port]::CreateViewForWidget to create
widget for the main web page.

[Avi (use Gerrit), 2013/01/08 20:51:15]

OK, gotcha.

+}
+
 gfx::NativeView WebContentsViewAndroid::GetNativeView() const {
   return content_view_core_;
 }