Allow embedders to provide a custom view for popup (select box) widgets,

content/browser/web_contents/web_contents_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_view_android.h"
 
 #include "base/logging.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/android/media_player_manager_android.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
@@ skipping 62 matching lines @@
   // |native_view_|, this has no effect without also instructing the
   // native view (i.e. ContentView) how to obtain a reference to this widget in
   // order to paint it. See ContentView::GetRenderWidgetHostViewAndroid for an
   // example of how this is achieved for InterstitialPages.
   RenderWidgetHostImpl* rwhi = RenderWidgetHostImpl::From(render_widget_host);
   RenderWidgetHostView* view = new RenderWidgetHostViewAndroid(
       rwhi, content_view_core_);
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewAndroid::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);

[Avi (use Gerrit), 2013/01/08 16:46:47]

In this and other platform files, why doesn't

return CreateViewForWidget(render_widget_host);

work? Why do you need to specify the routing of the call through the
RenderWidgetHostViewPort interface?

[rosca, 2013/01/08 19:34:29]

RenderWidgetHostView[Port]::CreateViewForWidget is the static creator for
platform specific RenderWidgetHostView*. 

WebContentsView::CreateViewForWidget is part of content API and it is used for
creating the main web page for curent web contents, its implementation usually
includes (besides widget creation) some web page specific initialisations and it
changes the WebContentsView's state with newly created web page. This is more
obvious in the win/mac implementation of WebContentsView::CreateViewForWidget.

WebContentsView[Platform]::CreateViewForWidget (for other platforms than
android) also uses RenderWidgetHostView[Port]::CreateViewForWidget to create
widget for the main web page.

[Avi (use Gerrit), 2013/01/08 20:51:15]

OK, gotcha.

+}
+
 gfx::NativeView WebContentsViewAndroid::GetNativeView() const {
   return content_view_core_;
 }
 
 gfx::NativeView WebContentsViewAndroid::GetContentNativeView() const {
   return content_view_core_;
 }
 
 gfx::NativeWindow WebContentsViewAndroid::GetTopLevelNativeWindow() const {
   return content_view_core_->GetWindowAndroid();
@@ skipping 116 matching lines @@
 // This is called when we the renderer asks us to take focus back (i.e., it has
 // iterated past the last focusable element on the page).
 void WebContentsViewAndroid::TakeFocus(bool reverse) {
   if (web_contents_->GetDelegate() &&
       web_contents_->GetDelegate()->TakeFocus(web_contents_, reverse))
     return;
   web_contents_->GetRenderWidgetHostView()->Focus();
 }
 
 } // namespace content