Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/svg/dom/SVGLengthList-basics.xhtml

Issue 1177303004: Updated SVGListPropertyHelper as per SVG2 Spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: small nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/TestExpectations ('K') | « LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt ('k') | LayoutTests/svg/dom/SVGLengthList-basics-expected.txt » ('j') | LayoutTests/svg/dom/SVGTransformList-more.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/dom/SVGLengthList-basics.xhtml
diff --git a/LayoutTests/svg/dom/SVGLengthList-basics.xhtml b/LayoutTests/svg/dom/SVGLengthList-basics.xhtml
index fb55181205f225edd3ebe53b15af643d029065f1..9deb143b31ee4e3344fdb7e9271c8678a80fa62b 100644
--- a/LayoutTests/svg/dom/SVGLengthList-basics.xhtml
+++ b/LayoutTests/svg/dom/SVGLengthList-basics.xhtml
@@ -50,32 +50,43 @@
shouldThrow("text1.x.baseVal.insertItemBefore(null)");
shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(1), 'aString')", "text1.x.baseVal.getItem(0)");
- shouldBe("text1.x.baseVal.numberOfItems", "3");
+ shouldBe("text1.x.baseVal.numberOfItems", "4");
shouldBe("text1.x.baseVal.getItem(0).value", "1000");
shouldBe("text1.x.baseVal.getItem(1).value", "500");
- shouldBe("text1.x.baseVal.getItem(2).value", "1500");
- shouldBeEqualToString("text1.getAttribute('x')", "1000 500 1500");
+ shouldBe("text1.x.baseVal.getItem(2).value", "1000");
+ shouldBe("text1.x.baseVal.getItem(3).value", "1500");
+ shouldBeEqualToString("text1.getAttribute('x')", "1000 500 1000 1500");
shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(1), text1)", "text1.x.baseVal.getItem(0)");
- shouldBe("text1.x.baseVal.numberOfItems", "3");
+ shouldBe("text1.x.baseVal.numberOfItems", "5");
shouldBe("text1.x.baseVal.getItem(0).value", "500");
shouldBe("text1.x.baseVal.getItem(1).value", "1000");
- shouldBe("text1.x.baseVal.getItem(2).value", "1500");
- shouldBeEqualToString("text1.getAttribute('x')", "500 1000 1500");
+ shouldBe("text1.x.baseVal.getItem(2).value", "500");
+ shouldBe("text1.x.baseVal.getItem(3).value", "1000");
+ shouldBe("text1.x.baseVal.getItem(4).value", "1500");
+
+ shouldBeEqualToString("text1.getAttribute('x')", "500 1000 500 1000 1500");
shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(1), null)", "text1.x.baseVal.getItem(0)");
- shouldBe("text1.x.baseVal.numberOfItems", "3");
+ shouldBe("text1.x.baseVal.numberOfItems", "6");
shouldBe("text1.x.baseVal.getItem(0).value", "1000");
shouldBe("text1.x.baseVal.getItem(1).value", "500");
- shouldBe("text1.x.baseVal.getItem(2).value", "1500");
- shouldBeEqualToString("text1.getAttribute('x')", "1000 500 1500");
+ shouldBe("text1.x.baseVal.getItem(2).value", "1000");
+ shouldBe("text1.x.baseVal.getItem(3).value", "500");
+ shouldBe("text1.x.baseVal.getItem(4).value", "1000");
+ shouldBe("text1.x.baseVal.getItem(5).value", "1500");
+ shouldBeEqualToString("text1.getAttribute('x')", "1000 500 1000 500 1000 1500");
shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(1), 0)", "text1.x.baseVal.getItem(0)");
- shouldBe("text1.x.baseVal.numberOfItems", "3");
+ shouldBe("text1.x.baseVal.numberOfItems", "7");
shouldBe("text1.x.baseVal.getItem(0).value", "500");
shouldBe("text1.x.baseVal.getItem(1).value", "1000");
- shouldBe("text1.x.baseVal.getItem(2).value", "1500");
- shouldBeEqualToString("text1.getAttribute('x')", "500 1000 1500");
+ shouldBe("text1.x.baseVal.getItem(2).value", "500");
+ shouldBe("text1.x.baseVal.getItem(3).value", "1000");
+ shouldBe("text1.x.baseVal.getItem(4).value", "500");
+ shouldBe("text1.x.baseVal.getItem(5).value", "1000");
+ shouldBe("text1.x.baseVal.getItem(6).value", "1500");
+ shouldBeEqualToString("text1.getAttribute('x')", "500 1000 500 1000 500 1000 1500");
shouldThrow("text1.x.baseVal.insertItemBefore(30, 0)");
shouldThrow("text1.x.baseVal.insertItemBefore('aString', 0)");
@@ -89,11 +100,11 @@
debug("");
debug("Test edge cases for insertItemBefore()");
shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(3), 3)", "text1.x.baseVal.getItem(3)");
- shouldBeEqualToString("text1.getAttribute('x')", "1 2 3 4");
- shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(1), 5)", "text1.x.baseVal.getItem(3)");
- shouldBeEqualToString("text1.getAttribute('x')", "1 3 4 2");
+ shouldBeEqualToString("text1.getAttribute('x')", "1 2 3 4 4");
+ shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(1), 5)", "text1.x.baseVal.getItem(5)");
+ shouldBeEqualToString("text1.getAttribute('x')", "1 2 3 4 4 2");
shouldBe("text1.x.baseVal.insertItemBefore(text1.x.baseVal.getItem(1), 0)", "text1.x.baseVal.getItem(0)");
- shouldBeEqualToString("text1.getAttribute('x')", "3 1 4 2");
+ shouldBeEqualToString("text1.getAttribute('x')", "2 1 2 3 4 4 2");
debug("");
debug("Set x='1 2 3 4' for text1");
@@ -152,9 +163,9 @@
shouldBe("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(3), 3)", "text1.x.baseVal.getItem(3)");
shouldBe("text1.x.baseVal.numberOfItems", "4");
shouldBeEqualToString("text1.getAttribute('x')", "1 2 3 4");
- shouldBe("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(1), 3)", "text1.x.baseVal.getItem(2)");
- shouldBe("text1.x.baseVal.numberOfItems", "3");
- shouldBeEqualToString("text1.getAttribute('x')", "1 3 2");
+ shouldBe("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(1), 3)", "text1.x.baseVal.getItem(3)");
+ shouldBe("text1.x.baseVal.numberOfItems", "4");
+ shouldBeEqualToString("text1.getAttribute('x')", "1 2 3 2");
shouldThrow("text1.x.baseVal.replaceItem(text1.x.baseVal.getItem(3), 4)");
debug("");
« LayoutTests/TestExpectations ('K') | « LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt ('k') | LayoutTests/svg/dom/SVGLengthList-basics-expected.txt » ('j') | LayoutTests/svg/dom/SVGTransformList-more.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698