Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt

Issue 1177303004: Updated SVGListPropertyHelper as per SVG2 Spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: small nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/TestExpectations ('K') | « LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml ('k') | LayoutTests/svg/dom/SVGLengthList-basics.xhtml » ('j') | LayoutTests/svg/dom/SVGTransformList-more.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt
diff --git a/LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt b/LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt
index 808c228d3979a1bc26e2b9a8c8c72398ef1c984f..5f58cb0a9cc2f0cd22d4647a394f9338c501a257 100644
--- a/LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt
+++ b/LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt
@@ -27,74 +27,82 @@ PASS text2.x.baseVal.getItem(2).value is 1000
PASS text2.x.baseVal.getItem(3) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (3) is greater than or equal to the maximum bound (3)..
Append fourth item x=900 to the text1 x list
-PASS text1.x.baseVal.appendItem(text1.x.baseVal.getItem(3)) is text1.x.baseVal.getItem(4)
-PASS text1.x.baseVal.numberOfItems is 5
+PASS text1.x.baseVal.appendItem(text1.x.baseVal.getItem(3)) is text1.x.baseVal.getItem(5)
+PASS text1.x.baseVal.numberOfItems is 6
PASS text1.x.baseVal.getItem(0).value is 500
PASS text1.x.baseVal.getItem(1).value is 50
PASS text1.x.baseVal.getItem(2).value is 100
-PASS text1.x.baseVal.getItem(3).value is 1000
-PASS text1.x.baseVal.getItem(4).value is 900
-PASS text1.x.baseVal.getItem(5) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (5) is greater than or equal to the maximum bound (5)..
+PASS text1.x.baseVal.getItem(3).value is 900
+PASS text1.x.baseVal.getItem(4).value is 1000
+PASS text1.x.baseVal.getItem(5).value is 900
+PASS text1.x.baseVal.getItem(6) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (6) is greater than or equal to the maximum bound (6)..
Append first item x=500 to the text1 x list
-PASS text1.x.baseVal.appendItem(text1.x.baseVal.getItem(0)) is text1.x.baseVal.getItem(4)
-PASS text1.x.baseVal.numberOfItems is 5
-PASS text1.x.baseVal.getItem(0).value is 50
-PASS text1.x.baseVal.getItem(1).value is 100
-PASS text1.x.baseVal.getItem(2).value is 1000
+PASS text1.x.baseVal.appendItem(text1.x.baseVal.getItem(0)) is text1.x.baseVal.getItem(6)
+PASS text1.x.baseVal.numberOfItems is 7
+PASS text1.x.baseVal.getItem(0).value is 500
+PASS text1.x.baseVal.getItem(1).value is 50
+PASS text1.x.baseVal.getItem(2).value is 100
PASS text1.x.baseVal.getItem(3).value is 900
-PASS text1.x.baseVal.getItem(4).value is 500
-PASS text1.x.baseVal.getItem(5) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (5) is greater than or equal to the maximum bound (5)..
+PASS text1.x.baseVal.getItem(4).value is 1000
+PASS text1.x.baseVal.getItem(5).value is 900
+PASS text1.x.baseVal.getItem(6).value is 500
+PASS text1.x.baseVal.getItem(7) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (7) is greater than or equal to the maximum bound (7)..
Append 'newLength1' to the text1 x list
-PASS text1.x.baseVal.appendItem(newLength1) is text1.x.baseVal.getItem(5)
-PASS text1.x.baseVal.numberOfItems is 6
-PASS text1.x.baseVal.getItem(0).value is 50
-PASS text1.x.baseVal.getItem(1).value is 100
-PASS text1.x.baseVal.getItem(2).value is 1000
+PASS text1.x.baseVal.appendItem(newLength1) is text1.x.baseVal.getItem(7)
+PASS text1.x.baseVal.numberOfItems is 8
+PASS text1.x.baseVal.getItem(0).value is 500
+PASS text1.x.baseVal.getItem(1).value is 50
+PASS text1.x.baseVal.getItem(2).value is 100
PASS text1.x.baseVal.getItem(3).value is 900
-PASS text1.x.baseVal.getItem(4).value is 500
-PASS text1.x.baseVal.getItem(5).value is 150
-PASS text1.x.baseVal.getItem(6) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (6) is greater than or equal to the maximum bound (6)..
+PASS text1.x.baseVal.getItem(4).value is 1000
+PASS text1.x.baseVal.getItem(5).value is 900
+PASS text1.x.baseVal.getItem(6).value is 500
+PASS text1.x.baseVal.getItem(7).value is 150
+PASS text1.x.baseVal.getItem(8) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (8) is greater than or equal to the maximum bound (8)..
Append third and fourth item of the text1 x list to the text2 x list
-PASS text2.x.baseVal.appendItem(text1.x.baseVal.getItem(2)).value is 1000
-PASS text2.x.baseVal.appendItem(text1.x.baseVal.getItem(2)).value is 900
-PASS text1.x.baseVal.numberOfItems is 4
-PASS text1.x.baseVal.getItem(0).value is 50
-PASS text1.x.baseVal.getItem(1).value is 100
-PASS text1.x.baseVal.getItem(2).value is 500
-PASS text1.x.baseVal.getItem(3).value is 150
-PASS text1.x.baseVal.getItem(4) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (4) is greater than or equal to the maximum bound (4)..
+PASS text2.x.baseVal.appendItem(text1.x.baseVal.getItem(2)).value is 100
+PASS text2.x.baseVal.appendItem(text1.x.baseVal.getItem(3)).value is 900
+PASS text1.x.baseVal.numberOfItems is 8
+PASS text1.x.baseVal.getItem(0).value is 500
+PASS text1.x.baseVal.getItem(1).value is 50
+PASS text1.x.baseVal.getItem(2).value is 100
+PASS text1.x.baseVal.getItem(3).value is 900
+PASS text1.x.baseVal.getItem(4).value is 1000
+PASS text1.x.baseVal.getItem(5).value is 900
+PASS text1.x.baseVal.getItem(6).value is 500
+PASS text1.x.baseVal.getItem(7).value is 150
+PASS text1.x.baseVal.getItem(8) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (8) is greater than or equal to the maximum bound (8)..
PASS text2.x.baseVal.numberOfItems is 5
PASS text2.x.baseVal.getItem(0).value is 50
PASS text2.x.baseVal.getItem(1).value is 100
PASS text2.x.baseVal.getItem(2).value is 1000
-PASS text2.x.baseVal.getItem(3).value is 1000
+PASS text2.x.baseVal.getItem(3).value is 100
PASS text2.x.baseVal.getItem(4).value is 900
PASS text2.x.baseVal.getItem(5) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (5) is greater than or equal to the maximum bound (5)..
PASS newLength2.value is 150
+PASS text1.x.baseVal.clear() is undefined.
Shuffle around items in text1 and text2 list using appendItem, to get x=50,100,150,... in both lists
-PASS text1.x.baseVal.appendItem(text1.x.baseVal.getItem(2)).value is 500
-PASS text2.x.baseVal.appendItem(newLength2).value is 150
-PASS text2.x.baseVal.appendItem(text2.x.baseVal.getItem(2)).value is 1000
-PASS text2.x.baseVal.appendItem(text2.x.baseVal.getItem(3)).value is 900
-PASS text2.x.baseVal.appendItem(text2.x.baseVal.getItem(2)).value is 1000
-PASS text1.x.baseVal.numberOfItems is 4
+PASS text1.x.baseVal.appendItem(text2.x.baseVal.getItem(0)).value is 50
+PASS text1.x.baseVal.appendItem(text2.x.baseVal.getItem(1)).value is 100
+PASS text1.x.baseVal.appendItem(newLength2).value is 150
+PASS text2.x.baseVal.clear() is undefined.
+PASS text2.x.baseVal.appendItem(text1.x.baseVal.getItem(0)).value is 50
+PASS text2.x.baseVal.appendItem(text1.x.baseVal.getItem(1)).value is 100
+PASS text2.x.baseVal.appendItem(text1.x.baseVal.getItem(2)).value is 150
+PASS text1.x.baseVal.numberOfItems is 3
PASS text1.x.baseVal.getItem(0).value is 50
PASS text1.x.baseVal.getItem(1).value is 100
PASS text1.x.baseVal.getItem(2).value is 150
-PASS text1.x.baseVal.getItem(3).value is 500
-PASS text1.x.baseVal.getItem(4) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (4) is greater than or equal to the maximum bound (4)..
-PASS text2.x.baseVal.numberOfItems is 6
+PASS text1.x.baseVal.getItem(4) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (4) is greater than the maximum bound (3)..
+PASS text2.x.baseVal.numberOfItems is 3
PASS text2.x.baseVal.getItem(0).value is 50
PASS text2.x.baseVal.getItem(1).value is 100
PASS text2.x.baseVal.getItem(2).value is 150
-PASS text2.x.baseVal.getItem(3).value is 1000
-PASS text2.x.baseVal.getItem(4).value is 900
-PASS text2.x.baseVal.getItem(5).value is 1000
-PASS text2.x.baseVal.getItem(6) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (6) is greater than or equal to the maximum bound (6)..
+PASS text2.x.baseVal.getItem(6) threw exception IndexSizeError: Failed to execute 'getItem' on 'SVGLengthList': The index provided (6) is greater than the maximum bound (3)..
The test passes if you only see 'PASS' messages, and all three text elements on top look the same
« LayoutTests/TestExpectations ('K') | « LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml ('k') | LayoutTests/svg/dom/SVGLengthList-basics.xhtml » ('j') | LayoutTests/svg/dom/SVGTransformList-more.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698