Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: lib/src/codegen/html_codegen.dart

Issue 1177253002: Fix runtime ordering and other minor fixes (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Refactor Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/runtime/dart_runtime.js ('K') | « lib/runtime/dart_runtime.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/html_codegen.dart
diff --git a/lib/src/codegen/html_codegen.dart b/lib/src/codegen/html_codegen.dart
index 2f1908b42ee5b6aab180af711ee10c8c99131814..31f25600c207a0262c0729f0ae47f96fee17974f 100644
--- a/lib/src/codegen/html_codegen.dart
+++ b/lib/src/codegen/html_codegen.dart
@@ -28,8 +28,8 @@ String generateEntryHtml(HtmlSourceNode root, CompilerOptions options) {
var document = root.document.clone(true);
var scripts = document.querySelectorAll('script[type="application/dart"]');
if (scripts.isEmpty) {
- _log.severe('No <script type="application/dart"> found in ${root.uri}');
- return null;
+ _log.warning('No <script type="application/dart"> found in ${root.uri}');
+ return '${document.outerHtml}\n';
vsm 2015/06/11 17:27:40 Note, todo requires --resources="todo.html". That
Jennifer Messerly 2015/06/11 18:28:25 yeah, I'd be totally fine removing this warning. A
}
scripts.skip(1).forEach((s) {
// TODO(sigmund): allow more than one Dart script tags?
« lib/runtime/dart_runtime.js ('K') | « lib/runtime/dart_runtime.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698