Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1177253002: Fix runtime ordering and other minor fixes (Closed)

Created:
5 years, 6 months ago by vsm
Modified:
5 years, 6 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix runtime ordering and other minor fixes Other than mirrors (coming next :-)), this gets angular todo running. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/cd399b17c24444fcaaf161b75aac9b24e67bae3b

Patch Set 1 #

Patch Set 2 : Refactor #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -13 lines) Patch
M lib/runtime/dart_runtime.js View 1 5 chunks +25 lines, -11 lines 2 comments Download
M lib/src/codegen/html_codegen.dart View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
vsm
Refactor
5 years, 6 months ago (2015-06-11 17:23:16 UTC) #1
vsm
https://codereview.chromium.org/1177253002/diff/20001/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1177253002/diff/20001/lib/runtime/dart_runtime.js#newcode1448 lib/runtime/dart_runtime.js:1448: import_('dart/core'); Note, I need to do a lazy import ...
5 years, 6 months ago (2015-06-11 17:27:40 UTC) #3
Leaf
lgtm https://codereview.chromium.org/1177253002/diff/20001/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1177253002/diff/20001/lib/runtime/dart_runtime.js#newcode1448 lib/runtime/dart_runtime.js:1448: import_('dart/core'); On 2015/06/11 17:27:40, vsm wrote: > Note, ...
5 years, 6 months ago (2015-06-11 18:05:04 UTC) #5
vsm
Committed patchset #2 (id:20001) manually as cd399b17c24444fcaaf161b75aac9b24e67bae3b (presubmit successful).
5 years, 6 months ago (2015-06-11 18:07:31 UTC) #6
Jennifer Messerly
5 years, 6 months ago (2015-06-11 18:28:25 UTC) #7
Message was sent while issue was closed.
lgtm too!

https://codereview.chromium.org/1177253002/diff/20001/lib/src/codegen/html_co...
File lib/src/codegen/html_codegen.dart (right):

https://codereview.chromium.org/1177253002/diff/20001/lib/src/codegen/html_co...
lib/src/codegen/html_codegen.dart:32: return '${document.outerHtml}\n';
On 2015/06/11 17:27:40, vsm wrote:
> Note, todo requires --resources="todo.html".  That file gets processed here,
but
> it only has angular templates, no dart code.

yeah, I'd be totally fine removing this warning. An HTML file is an HTML file
... if we need to serve it, we serve it. Not having a Dart script is not an
error in an HTML file :)

Powered by Google App Engine
This is Rietveld 408576698