Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1177213003: Add <stdarg.h> include required for va_start/va_end in GCC (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add <stdarg.h> include required for va_start/va_end in GCC https://codereview.chromium.org/1181713004 removed some base/port.h includes, which in turn includes <stdarg.h>. This include is needed to compile with GCC, at least on some systems. BUG=138542 NOPRESUBMIT=true Committed: https://crrev.com/83cdb82ced342408cfb3fa3327c05e429f044ef7 Cr-Commit-Position: refs/heads/master@{#334260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/disk_cache/blockfile/trace.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-06-12 12:52:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177213003/1
5 years, 6 months ago (2015-06-12 12:52:58 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70480)
5 years, 6 months ago (2015-06-12 13:00:23 UTC) #6
philipj_slow
PTAL
5 years, 6 months ago (2015-06-12 14:05:11 UTC) #8
mattm
lgtm
5 years, 6 months ago (2015-06-12 21:48:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177213003/1
5 years, 6 months ago (2015-06-12 21:51:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70657)
5 years, 6 months ago (2015-06-12 22:01:52 UTC) #13
philipj_slow
Presubmit fails because "These files spam the console log with LOG(INFO)" but the LOG() statement ...
5 years, 6 months ago (2015-06-12 22:15:23 UTC) #14
mattm
On 2015/06/12 22:15:23, philipj wrote: > Presubmit fails because "These files spam the console log ...
5 years, 6 months ago (2015-06-12 22:19:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177213003/1
5 years, 6 months ago (2015-06-12 22:28:20 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 22:30:29 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 22:31:27 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83cdb82ced342408cfb3fa3327c05e429f044ef7
Cr-Commit-Position: refs/heads/master@{#334260}

Powered by Google App Engine
This is Rietveld 408576698