Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/metrics_test.cc

Issue 1177153005: Enables clean VM shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Kill isolates from the service isolate Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/message_handler.cc ('K') | « runtime/vm/message_handler_test.cc ('k') | runtime/vm/native_api_impl.cc » ('j') | runtime/vm/thread_pool.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/metrics_test.cc
diff --git a/runtime/vm/metrics_test.cc b/runtime/vm/metrics_test.cc
index 364c946422c169aa43506174f61889cb36a4821e..2221ca422b588baa031acc2627ef2ae9487e4d30 100644
--- a/runtime/vm/metrics_test.cc
+++ b/runtime/vm/metrics_test.cc
@@ -28,6 +28,8 @@ UNIT_TEST_CASE(Metric_Simple) {
EXPECT_EQ(1, metric.value());
metric.set_value(44);
EXPECT_EQ(44, metric.value());
+
+ Dart::ShutdownIsolate();
}
class MyMetric : public Metric {
@@ -64,6 +66,8 @@ UNIT_TEST_CASE(Metric_OnDemand) {
"\"foobar\",\"unit\":\"byte\","
"\"fixedId\":true,\"id\":\"metrics\\/native\\/a.b.c\""
",\"value\":99.000000}", json);
+
+ Dart::ShutdownIsolate();
}
} // namespace dart
« runtime/vm/message_handler.cc ('K') | « runtime/vm/message_handler_test.cc ('k') | runtime/vm/native_api_impl.cc » ('j') | runtime/vm/thread_pool.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698