runtime/vm/message_handler_test.cc - Issue 1177153005: Enables clean VM shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/message_handler_test.cc

Issue 1177153005: Enables clean VM shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Kill isolates from the service isolate Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/message_handler_test.cc

diff --git a/runtime/vm/message_handler_test.cc b/runtime/vm/message_handler_test.cc

index 7bfcb9aa557d851cfc658a40d22ac262e16ceb32..119e1c82018ee74acf4615a4f7061eac09113d2c 100644

--- a/runtime/vm/message_handler_test.cc

+++ b/runtime/vm/message_handler_test.cc

@@ -288,7 +288,6 @@ static void SendMessages(uword param) {

UNIT_TEST_CASE(MessageHandler_Run) {

- ThreadPool pool;

TestMessageHandler handler;

MessageHandlerTestPeer handler_peer(&handler);

int sleep = 0;

@@ -297,8 +296,7 @@ UNIT_TEST_CASE(MessageHandler_Run) {

EXPECT(!handler.HasLivePorts());

handler_peer.increment_live_ports();

- handler.Run(&pool,

- TestStartFunction,

+ handler.Run(TestStartFunction,

TestEndFunction,

reinterpret_cast<uword>(&handler));

Dart_Port port = PortMap::CreatePort(&handler);