Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1177073007: Revert of Make GN build match gyp (/bigobj everywhere) and remove now-unnecessary settings (Closed)

Created:
5 years, 6 months ago by Marijn Kruisselbrink
Modified:
5 years, 6 months ago
Reviewers:
brettw, jam, brucedawson, scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam, brucedawson, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make GN build match gyp (/bigobj everywhere) and remove now-unnecessary settings (patchset #1 id:1 of https://codereview.chromium.org/1190813002/) Reason for revert: C:\b\build\slave\Win_x64_Builder__dbg_\build\src\content\common\content_message_generator.cc : fatalerror C1128: number of sections exceeded object file format limit : compile with /bigobj http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/9331/steps/compile/logs/stdio Original issue's description: > Make GN build match gyp (/bigobj everywhere) and remove now-unnecessary settings > > Previously added to gyp by https://codereview.chromium.org/1188603004. > > R=brettw@chromium.org,jam@chromium.org > BUG=173851 > > Committed: https://crrev.com/c4d566d2e08b7ec74bba484676a9b408d3866c42 > Cr-Commit-Position: refs/heads/master@{#334734} TBR=brettw@chromium.org,jam@chromium.org,brucedawson@chromium.org,scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=173851 Committed: https://crrev.com/5086df227d96512f77e0696d113a4d15a63285bb Cr-Commit-Position: refs/heads/master@{#334745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M content/content.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M content/content_shell_and_tests.gyp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Marijn Kruisselbrink
Created Revert of Make GN build match gyp (/bigobj everywhere) and remove now-unnecessary settings
5 years, 6 months ago (2015-06-16 23:41:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177073007/1
5 years, 6 months ago (2015-06-16 23:41:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 23:42:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5086df227d96512f77e0696d113a4d15a63285bb Cr-Commit-Position: refs/heads/master@{#334745}
5 years, 6 months ago (2015-06-16 23:43:51 UTC) #4
scottmg
5 years, 6 months ago (2015-06-17 03:39:40 UTC) #5
Message was sent while issue was closed.
Thanks for reverting, sorry for the breakage.

I'm not sure what happened, that flag is supposed to be on globally now.

Powered by Google App Engine
This is Rietveld 408576698