Issue 1177053002: Init GrGLSLCaps fields from inside GrGLCaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177053002: Init GrGLSLCaps fields from inside GrGLCaps (Closed)

Created:
5 years, 6 months ago by Chris Dalton

Modified:
5 years, 6 months ago

Reviewers:
jvanverth1, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Init GrGLSLCaps fields from inside GrGLCaps Fixes circular dependencies by allowing the initialization to be done intertwined. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4cd6713af1c699b79e04b590109768300faee531

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -123 lines)			Patch
M	include/gpu/GrCaps.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	5 chunks	+104 lines, -117 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177053002/1

5 years, 6 months ago (2015-06-11 02:18:15 UTC) #6

commit-bot: I haz the power

5 years, 6 months ago (2015-06-11 02:23:51 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4cd6713af1c699b79e04b590109768300faee531