Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1177043009: Make sure to flatten names before lookup. Lookup using cons strings is really slow. (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure to flatten names before lookup. Lookup using cons strings is really slow. Restores SortNumbers perf degrade BUG=chromium:495949, v8:4137 LOG=n Committed: https://crrev.com/d69ead663c6ec5aa989ef45012d86b04129e8dfb Cr-Commit-Position: refs/heads/master@{#29095}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/lookup.h View 1 5 chunks +5 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Toon Verwaest
Restores SortNumbers perf degrade
5 years, 6 months ago (2015-06-17 15:14:00 UTC) #2
Toon Verwaest
I mean, ptal ;)
5 years, 6 months ago (2015-06-17 15:14:29 UTC) #3
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-17 15:15:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177043009/1
5 years, 6 months ago (2015-06-17 15:23:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/6818)
5 years, 6 months ago (2015-06-17 15:27:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177043009/20001
5 years, 6 months ago (2015-06-17 15:37:23 UTC) #11
Jakob Kummerow
Patch set 2 still LGTM.
5 years, 6 months ago (2015-06-17 15:37:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-17 16:05:27 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 16:05:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d69ead663c6ec5aa989ef45012d86b04129e8dfb
Cr-Commit-Position: refs/heads/master@{#29095}

Powered by Google App Engine
This is Rietveld 408576698