Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: src/objects.h

Issue 1177043009: Make sure to flatten names before lookup. Lookup using cons strings is really slow. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lookup.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 4a683405bd40980d9d93f23d62727aa0800da62e..f5ce1d6c4251ff0582b4ec7fa7d1cb10aea7ff21 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -8592,6 +8592,11 @@ class Name: public HeapObject {
// If the name is private, it can only name own properties.
inline bool IsPrivate();
+ // If the name is a non-flat string, this method returns a flat version of the
+ // string. Otherwise it'll just return the input.
+ static inline Handle<Name> Flatten(Handle<Name> name,
+ PretenureFlag pretenure = NOT_TENURED);
+
DECLARE_CAST(Name)
DECLARE_PRINTER(Name)
« no previous file with comments | « src/lookup.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698