cc: Turn impl_side_painting and use_one_copy on in LayerTreeSettings.

cc: Turn impl_side_painting and use_one_copy on in LayerTreeSettings.

Make these default to true in LayerTreeSettings so that all unit tests
will use them automatically unless they opt out. Fix all the tests
that crashed with this on, due to having a null cc::TaskGraphRunner.

R=enne, vmpstr
BUG=413479
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true

Committed: https://crrev.com/cf6105879590dbf12e023250821ddc9e3f807524
Cr-Commit-Position: refs/heads/master@{#334726}

[danakj, 2015-06-15 22:45:48]

danakj@chromium.org changed reviewers:
+ sievers@chromium.org

[danakj, 2015-06-15 22:45:49]

+sievers for content/

[danakj, 2015-06-15 22:46:28]

danakj@chromium.org changed reviewers:
+ aelias@chromium.org
- sievers@chromium.org

[danakj, 2015-06-15 22:46:29]

On 2015/06/15 22:45:49, danakj wrote:
> +sievers for content/

oh sievers is out, +aelias

[enne (OOO), 2015-06-15 22:58:46]

https://codereview.chromium.org/1177033008/diff/1/cc/layers/picture_layer_uni...
File cc/layers/picture_layer_unittest.cc (right):

https://codereview.chromium.org/1177033008/diff/1/cc/layers/picture_layer_uni...
cc/layers/picture_layer_unittest.cc:132: settings.use_one_copy = false;
Why does this test need zero copy?

https://codereview.chromium.org/1177033008/diff/1/cc/layers/scrollbar_layer_u...
File cc/layers/scrollbar_layer_unittest.cc (right):

https://codereview.chromium.org/1177033008/diff/1/cc/layers/scrollbar_layer_u...
cc/layers/scrollbar_layer_unittest.cc:125: layer_tree_settings_.use_one_copy =
false;
Why does this test need zero copy?

https://codereview.chromium.org/1177033008/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1177033008/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:236:
DCHECK_IMPLIES(settings.impl_side_painting, task_graph_runner_);
Do we have a one copy implies not zero copy and zero copy implies not one copy
dcheck anywhere too?

[aelias_OOO_until_Jul13, 2015-06-15 23:00:18]

content/browser/renderer_host/ lgtm

[danakj, 2015-06-15 23:02:35]

https://codereview.chromium.org/1177033008/diff/1/cc/layers/picture_layer_uni...
File cc/layers/picture_layer_unittest.cc (right):

https://codereview.chromium.org/1177033008/diff/1/cc/layers/picture_layer_uni...
cc/layers/picture_layer_unittest.cc:132: settings.use_one_copy = false;
On 2015/06/15 22:58:46, enne wrote:
> Why does this test need zero copy?

No scheduler.

https://codereview.chromium.org/1177033008/diff/1/cc/layers/scrollbar_layer_u...
File cc/layers/scrollbar_layer_unittest.cc (right):

https://codereview.chromium.org/1177033008/diff/1/cc/layers/scrollbar_layer_u...
cc/layers/scrollbar_layer_unittest.cc:125: layer_tree_settings_.use_one_copy =
false;
On 2015/06/15 22:58:46, enne wrote:
> Why does this test need zero copy?

No scheduler.

https://codereview.chromium.org/1177033008/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1177033008/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:236:
DCHECK_IMPLIES(settings.impl_side_painting, task_graph_runner_);
On 2015/06/15 22:58:46, enne wrote:
> Do we have a one copy implies not zero copy and zero copy implies not one copy
> dcheck anywhere too?

We do in RenderProcessHostImpl not in cc. I can add.

[danakj, 2015-06-15 23:05:15]

PTAL

[enne (OOO), 2015-06-15 23:07:10]

lgtm, thanks!

[danakj, 2015-06-15 23:13:56]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-06-15 23:13:57]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1177033008/#ps30043
(title: "implon: rebase")

[commit-bot: I haz the power, 2015-06-15 23:14:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177033008/30043

[commit-bot: I haz the power, 2015-06-15 23:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 23:44:45]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[danakj, 2015-06-16 17:03:41]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-06-16 17:03:41]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1177033008/#ps50001
(title: "implon: .")

[commit-bot: I haz the power, 2015-06-16 17:05:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177033008/50001

[commit-bot: I haz the power, 2015-06-16 17:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 17:52:13]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[danakj, 2015-06-16 18:04:39]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-06-16 18:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1177033008/#ps70001
(title: "implon: blinktests")

[commit-bot: I haz the power, 2015-06-16 18:08:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177033008/70001

[commit-bot: I haz the power, 2015-06-16 18:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 18:47:00]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[danakj, 2015-06-16 19:01:43]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-06-16 19:01:44]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1177033008/#ps90001
(title: "implon: fixwebkittests")

[commit-bot: I haz the power, 2015-06-16 19:02:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177033008/90001

[danakj, 2015-06-16 19:06:04]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2015-06-16 19:06:05]

+sky can you review content/test please

[commit-bot: I haz the power, 2015-06-16 19:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 19:14:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2015-06-16 20:26:00]

LGTM

[danakj, 2015-06-16 20:26:08]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-06-16 20:28:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177033008/90001

[commit-bot: I haz the power, 2015-06-16 22:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 22:38:58]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2015-06-16 22:41:50]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-06-16 22:42:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177033008/90001

[no sievers, 2015-06-16 22:47:32]

content lgtm

[commit-bot: I haz the power, 2015-06-16 22:49:07]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2015-06-16 22:50:05]

Patchset 6 (id:??) landed as
https://crrev.com/cf6105879590dbf12e023250821ddc9e3f807524
Cr-Commit-Position: refs/heads/master@{#334726}