Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1176923003: Update flags passed to Android GPU bots to exclude running skps and image sources. (Closed)

Created:
5 years, 6 months ago by djsollen
Modified:
5 years, 6 months ago
Reviewers:
bsalomon, borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update flags passed to Android GPU bots to exclude running skps and image sources. Committed: https://skia.googlesource.com/skia/+/e21585eabf18b9919701b14576b6876c0fd86735

Patch Set 1 #

Total comments: 1

Patch Set 2 : tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -126 lines) Patch
M tools/dm_flags.json View 1 9 chunks +12 lines, -120 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +5 lines, -6 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
djsollen
https://codereview.chromium.org/1176923003/diff/1/tools/dm_flags.py File tools/dm_flags.py (left): https://codereview.chromium.org/1176923003/diff/1/tools/dm_flags.py#oldcode124 tools/dm_flags.py:124: blacklist.extend('gpu skp _ _ msaa skp _ _'.split(' ')) ...
5 years, 6 months ago (2015-06-10 15:41:12 UTC) #2
borenet
On 2015/06/10 15:41:12, djsollen wrote: > https://codereview.chromium.org/1176923003/diff/1/tools/dm_flags.py > File tools/dm_flags.py (left): > > https://codereview.chromium.org/1176923003/diff/1/tools/dm_flags.py#oldcode124 > ...
5 years, 6 months ago (2015-06-10 15:47:30 UTC) #3
bsalomon
lgtm
5 years, 6 months ago (2015-06-10 15:52:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176923003/20001
5 years, 6 months ago (2015-06-10 15:52:42 UTC) #6
mtklein
https://codereview.chromium.org/1176923003/diff/20001/tools/dm_flags.py File tools/dm_flags.py (left): https://codereview.chromium.org/1176923003/diff/20001/tools/dm_flags.py#oldcode125 tools/dm_flags.py:125: blacklist.extend('gpu image decode _ msaa image decode _'.split(' ')) ...
5 years, 6 months ago (2015-06-10 15:56:19 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 16:05:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e21585eabf18b9919701b14576b6876c0fd86735

Powered by Google App Engine
This is Rietveld 408576698