Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: tools/dm_flags.py

Issue 1176923003: Update flags passed to Android GPU bots to exclude running skps and image sources. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index fd945a5b546e85320417509ab9a595979b98da0b..ea657f8e6c43fda33f061478bc3602249f53646e 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -118,12 +118,11 @@ def get_args(bot):
blacklist.extend('pdf gm _ fontmgr_iter_factory'.split(' '))
# Drawing SKPs or images into GPU canvases is a New Thing.
- # It seems like we're running out of RAM on some Android bots, so start off
- # with a very wide blacklist disabling all these tests on all Android bots.
- if 'Android' in bot: # skia:3255
- blacklist.extend('gpu skp _ _ msaa skp _ _'.split(' '))
- blacklist.extend('gpu image decode _ msaa image decode _'.split(' '))
mtklein 2015/06/10 15:56:19 FWIW, msaa blacklisted both msaa4 and msaa16. The
- blacklist.extend('gpu image subset _ msaa image subset _'.split(' '))
+ # We are running out of RAM on some Android bots, so we are restricting
+ # all GPU Android bots to only run tests and GMs.
+ if ('Android' in bot and
+ 'GPU' in bot):
+ args.extend('--src tests gm'.split(' '))
if 'Valgrind' in bot:
# PDF + .webp -> jumps depending on uninitialized memory. skia:3505
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698