Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1176833002: Removing FindLegendOption (Closed)

Created:
5 years, 6 months ago by a.berwal
Modified:
5 years, 6 months ago
Reviewers:
a.suchit2, a.suchit, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing FindLegendOption FindLegendOption::IncludeFloatingOrOutOfFlow is never used so removing it. BUG=498533 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197012

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/core/layout/LayoutFieldset.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/layout/LayoutFieldset.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/FieldsetPainter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
a.suchit2
https://codereview.chromium.org/1176833002/diff/1/Source/core/layout/LayoutFieldset.h File Source/core/layout/LayoutFieldset.h (right): https://codereview.chromium.org/1176833002/diff/1/Source/core/layout/LayoutFieldset.h#newcode35 Source/core/layout/LayoutFieldset.h:35: LayoutBox* findLegend() const; Change function's name as "findInFlowLegend".
5 years, 6 months ago (2015-06-10 08:00:11 UTC) #2
a.berwal
On 2015/06/10 08:00:11, a.suchit2 wrote: > https://codereview.chromium.org/1176833002/diff/1/Source/core/layout/LayoutFieldset.h > File Source/core/layout/LayoutFieldset.h (right): > > https://codereview.chromium.org/1176833002/diff/1/Source/core/layout/LayoutFieldset.h#newcode35 > ...
5 years, 6 months ago (2015-06-10 08:27:02 UTC) #3
a.suchit2
lgtm
5 years, 6 months ago (2015-06-10 09:01:19 UTC) #4
a.berwal
PTAL
5 years, 6 months ago (2015-06-10 11:54:34 UTC) #6
esprehn
Not sure the rename is really needed, but this seems fine. lgtm
5 years, 6 months ago (2015-06-12 06:17:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176833002/20001
5 years, 6 months ago (2015-06-12 06:18:18 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 07:40:22 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197012

Powered by Google App Engine
This is Rietveld 408576698