Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: Source/core/layout/LayoutFieldset.cpp

Issue 1176833002: Removing FindLegendOption (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixing nits Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutFieldset.h ('k') | Source/core/paint/FieldsetPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutFieldset.cpp
diff --git a/Source/core/layout/LayoutFieldset.cpp b/Source/core/layout/LayoutFieldset.cpp
index a08e0042a20f7d8665bfd883a20687113cd23c26..232e4c8f98522d0c890f94a307df33cbc6da9957 100644
--- a/Source/core/layout/LayoutFieldset.cpp
+++ b/Source/core/layout/LayoutFieldset.cpp
@@ -45,7 +45,7 @@ LayoutFieldset::LayoutFieldset(Element* element)
void LayoutFieldset::computePreferredLogicalWidths()
{
LayoutBlockFlow::computePreferredLogicalWidths();
- if (LayoutBox* legend = findLegend()) {
+ if (LayoutBox* legend = findInFlowLegend()) {
int legendMinWidth = legend->minPreferredLogicalWidth();
Length legendMarginLeft = legend->style()->marginLeft();
@@ -63,7 +63,7 @@ void LayoutFieldset::computePreferredLogicalWidths()
LayoutObject* LayoutFieldset::layoutSpecialExcludedChild(bool relayoutChildren, SubtreeLayoutScope&)
{
- LayoutBox* legend = findLegend();
+ LayoutBox* legend = findInFlowLegend();
if (legend) {
if (relayoutChildren)
legend->setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::FieldsetChanged);
@@ -125,10 +125,10 @@ LayoutObject* LayoutFieldset::layoutSpecialExcludedChild(bool relayoutChildren,
return legend;
}
-LayoutBox* LayoutFieldset::findLegend(FindLegendOption option) const
+LayoutBox* LayoutFieldset::findInFlowLegend() const
{
for (LayoutObject* legend = firstChild(); legend; legend = legend->nextSibling()) {
- if (option == IgnoreFloatingOrOutOfFlow && legend->isFloatingOrOutOfFlowPositioned())
+ if (legend->isFloatingOrOutOfFlowPositioned())
continue;
if (isHTMLLegendElement(legend->node()))
« no previous file with comments | « Source/core/layout/LayoutFieldset.h ('k') | Source/core/paint/FieldsetPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698