Fixing formats for Video Capture Device unittest

This CL fixes some issues that came up Video Capture Device unittest, where it tries to capture format that are not supported by the device and makes size assumptions on it-device being daisy in this case-.

- We check the exact size if returned type is equal to the requested type PIXEL_FORMAT_I420.
- If it is some other format, excluding PIXEL_FORMAT_MJPEG, we make the assumption that it is at least 12 BPP.

BUG=482875
Committed: https://crrev.com/ef4d387401d41721b7a1244417cc507e2e09dc42
Cr-Commit-Position: refs/heads/master@{#333761}

[emircan, 2015-06-09 21:50:19]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org

[emircan, 2015-06-09 21:50:43]

Please take a look.

[emircan, 2015-06-09 22:11:57]

Patchset #1 (id:1) has been deleted

[mcasas, 2015-06-10 00:48:04]

https://codereview.chromium.org/1176613003/diff/20001/media/video/capture/vid...
File media/video/capture/video_capture_device_unittest.cc (right):

https://codereview.chromium.org/1176613003/diff/20001/media/video/capture/vid...
media/video/capture/video_capture_device_unittest.cc:325:
EXPECT_EQ(static_cast<size_t>(width * height * 3 / 2),
What about counting pixels instead of bytes?

if (last_format().pixel_format != PIXEL_FORMAT_MJPEG)
  EXPECT_EQ(gfx::Size(width, height).GetArea(), last_format().GetArea());


And it might work for MJPEG as well, not 100% sure.

https://codereview.chromium.org/1176613003/diff/20001/media/video/capture/vid...
media/video/capture/video_capture_device_unittest.cc:364: if
(last_format().pixel_format == PIXEL_FORMAT_I420) {
Idem.

[emircan, 2015-06-10 01:19:59]

https://codereview.chromium.org/1176613003/diff/20001/media/video/capture/vid...
File media/video/capture/video_capture_device_unittest.cc (right):

https://codereview.chromium.org/1176613003/diff/20001/media/video/capture/vid...
media/video/capture/video_capture_device_unittest.cc:325:
EXPECT_EQ(static_cast<size_t>(width * height * 3 / 2),
On 2015/06/10 00:48:04, mcasas wrote:
> What about counting pixels instead of bytes?
> 
> if (last_format().pixel_format != PIXEL_FORMAT_MJPEG)
>   EXPECT_EQ(gfx::Size(width, height).GetArea(), last_format().GetArea());
> 
> 
> And it might work for MJPEG as well, not 100% sure.

Done.

[mcasas, 2015-06-10 02:33:21]

lgtm

[emircan, 2015-06-10 18:05:50]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2015-06-10 18:06:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176613003/40001

[commit-bot: I haz the power, 2015-06-10 18:14:15]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-06-10 18:16:11]

Patchset 2 (id:??) landed as
https://crrev.com/ef4d387401d41721b7a1244417cc507e2e09dc42
Cr-Commit-Position: refs/heads/master@{#333761}