Fixing formats for Video Capture Device unittest

media/video/capture/video_capture_device_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 303 matching lines @@
 
   VideoCaptureParams capture_params;
   capture_params.requested_format.frame_size.SetSize(width, height);
   capture_params.requested_format.frame_rate = 30.0f;
   capture_params.requested_format.pixel_format = PIXEL_FORMAT_I420;
   device->AllocateAndStart(capture_params, client_.Pass());
   // Get captured video frames.
   WaitForCapturedFrame();
   EXPECT_EQ(last_format().frame_size.width(), width);
   EXPECT_EQ(last_format().frame_size.height(), height);
-  if (last_format().pixel_format != PIXEL_FORMAT_MJPEG)
+  if (last_format().pixel_format == PIXEL_FORMAT_I420) {
+    EXPECT_EQ(static_cast<size_t>(width * height * 3 / 2),

[mcasas, 2015/06/10 00:48:04]

What about counting pixels instead of bytes?

if (last_format().pixel_format != PIXEL_FORMAT_MJPEG)
  EXPECT_EQ(gfx::Size(width, height).GetArea(), last_format().GetArea());


And it might work for MJPEG as well, not 100% sure.

[emircan, 2015/06/10 01:19:59]

Done.

+              last_format().ImageAllocationSize());
+  } else if ((last_format().pixel_format != PIXEL_FORMAT_MJPEG)) {
     EXPECT_LE(static_cast<size_t>(width * height * 3 / 2),
               last_format().ImageAllocationSize());
+  }
   device->StopAndDeAllocate();
 }
 
 #if !defined(OS_ANDROID)
 INSTANTIATE_TEST_CASE_P(MAYBE_VideoCaptureDeviceTests,
                         VideoCaptureDeviceTest,
                         testing::ValuesIn(kCaptureSizes));
 #endif
 
 TEST_F(VideoCaptureDeviceTest, MAYBE_AllocateBadSize) {
   names_ = EnumerateDevices();
   if (names_->empty()) {
     DVLOG(1) << "No camera available. Exiting test.";
     return;
   }
   scoped_ptr<VideoCaptureDevice> device(
       video_capture_device_factory_->Create(names_->front()));
   ASSERT_TRUE(device);
 
   EXPECT_CALL(*client_, OnError(_)).Times(0);
 
+  const int width = 640;
+  const int height = 480;
+
   VideoCaptureParams capture_params;
   capture_params.requested_format.frame_size.SetSize(637, 472);
   capture_params.requested_format.frame_rate = 35;
   capture_params.requested_format.pixel_format = PIXEL_FORMAT_I420;
   device->AllocateAndStart(capture_params, client_.Pass());
   WaitForCapturedFrame();
   device->StopAndDeAllocate();
-  EXPECT_EQ(last_format().frame_size.width(), 640);
-  EXPECT_EQ(last_format().frame_size.height(), 480);
-  EXPECT_EQ(static_cast<size_t>(640 * 480 * 3 / 2),
-            last_format().ImageAllocationSize());
+  EXPECT_EQ(last_format().frame_size.width(), width);
+  EXPECT_EQ(last_format().frame_size.height(), height);
+  if (last_format().pixel_format == PIXEL_FORMAT_I420) {

[mcasas, 2015/06/10 00:48:04]

Idem.

+    EXPECT_EQ(static_cast<size_t>(width * height * 3 / 2),
+              last_format().ImageAllocationSize());
+  } else if ((last_format().pixel_format != PIXEL_FORMAT_MJPEG)) {
+    EXPECT_LE(static_cast<size_t>(width * height * 3 / 2),
+              last_format().ImageAllocationSize());
+  }
 }
 
 // Cause hangs on Windows Debug. http://crbug.com/417824
 #if defined(OS_WIN) && !defined(NDEBUG)
 #define MAYBE_ReAllocateCamera DISABLED_ReAllocateCamera
 #else
 #define MAYBE_ReAllocateCamera ReAllocateCamera
 #endif
 
 TEST_F(VideoCaptureDeviceTest, MAYBE_ReAllocateCamera) {
@@ skipping 98 matching lines @@
   // Use PIXEL_FORMAT_MAX to iterate all device names for testing
   // GetDeviceSupportedFormats().
   scoped_ptr<VideoCaptureDevice::Name> name =
       GetFirstDeviceNameSupportingPixelFormat(PIXEL_FORMAT_MAX);
   // Verify no camera returned for PIXEL_FORMAT_MAX. Nothing else to test here
   // since we cannot forecast the hardware capabilities.
   ASSERT_FALSE(name);
 }
 
 };  // namespace media