chromium_trybot: use matching_exes from analyze rather than compile_targets

chromium_trybot: use matching_exes from analyze rather than compile_targets

This should be a step towards removing some recipe-side hacks for analyze.

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295621

[Paweł Hajdan Jr., 2015-06-10 14:29:17]

phajdan.jr@chromium.org changed reviewers:
+ sergiyb@chromium.org, sky@chromium.org

[Paweł Hajdan Jr., 2015-06-10 14:29:17]

Please review. One thing that worries me is that it's difficult to test this
change.

The hacks I refer to is mostly this code:

    if 'all' in compile_targets:
      compile_targets = self.m.filter.compile_targets
    else:
      compile_targets = list(set(compile_targets) &
                             set(self.m.filter.compile_targets))
    # Always add |matching_exes|. They will be covered by |compile_targets|,
    # but adding |matching_exes| makes determing if conditional tests are
    # necessary easier. For example, if we didn't do this we could end up
    # with chrome_run as a compile_target and not chrome (since chrome_run
    # depends upon chrome). This results in not picking up
    # NaclIntegrationTest as it depends upon chrome not chrome_run.
    compile_targets = list(set(self.m.filter.matching_exes + compile_targets))

[sky, 2015-06-10 15:54:36]

LGTM

[Sergiy Byelozyorov, 2015-06-11 08:39:13]

On 2015/06/10 15:54:36, sky wrote:
> LGTM

What is the semantic for matching_exes?

[Paweł Hajdan Jr., 2015-06-11 10:29:59]

On 2015/06/11 at 08:39:13, sergiyb wrote:
> What is the semantic for matching_exes?

I'd be happy to explain that offline. What I found most useful was reading
analyzer code
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gyp/pylib/gy...

I'm planning to land this soon because it's a really risky change and so I'd
like to ensure plenty of time to monitor before peak MTV working hours.

[Paweł Hajdan Jr., 2015-06-11 10:30:07]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2015-06-11 10:30:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176553003/1

[commit-bot: I haz the power, 2015-06-11 10:36:29]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295621