scripts/slave/recipes/chromium_trybot.py - Issue 1176553003: chromium_trybot: use matching_exes from analyze rather than compile_targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 1176553003: chromium_trybot: use matching_exes from analyze rather than compile_targets (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index 1154fe7be88a505acc8c20c45511120c52e8b54e..ac9b69dc017d3b62e10fe62252ef3961091b55a3 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -421,7 +421,7 @@ def _GenStepsInternal(api):

override_bot_type='builder_tester',

override_tests=tests)

- requires_compile, _, compile_targets = \

+ requires_compile, matching_exes, compile_targets = \

api.chromium_tests.analyze(

affected_files,

all_compile_targets(api, tests + tests_including_triggered),

@@ -431,9 +431,9 @@ def _GenStepsInternal(api):

if not requires_compile:

return

- tests = tests_in_compile_targets(api, compile_targets, tests)

+ tests = tests_in_compile_targets(api, matching_exes, tests)

tests_including_triggered = tests_in_compile_targets(

- api, compile_targets, tests_including_triggered)

+ api, matching_exes, tests_including_triggered)

api.chromium_tests.compile_specific_targets(

bot_config['mastername'],