Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1176393002: Revert of [arm64][turbofan]: Handle any immediate shift. (Closed)

Created:
5 years, 6 months ago by jbramley
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, m.m.capewell
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [arm64][turbofan]: Handle any immediate shift. (patchset #1 id:1 of https://codereview.chromium.org/1179733004/) Reason for revert: Breaks InstructionSelectorTest.Word64ShrWithWord64AndWithImmediate on debug builds (but not optdebug builds). I'll investigate. Original issue's description: > [arm64][turbofan]: Handle any immediate shift. > > With this patch, we can generate simple immediate-shift instructions for > immediates outside the range "0 <= imm < width". Several related > instruction selectors have also been updated accordingly. > > Example of generated code: > > ---- Before --- ---- After ---- > movz w0, #33 lsr w0, w1, #1 > lsr w0, w1, w0 > > BUG= > > Committed: https://crrev.com/36d771bbfa4af5efcc1c1dcf5b234445cb7ee722 > Cr-Commit-Position: refs/heads/master@{#28943} TBR=bmeurer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/14755c0a2d8342c50523a65707a5ab79fd778df5 Cr-Commit-Position: refs/heads/master@{#28944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -136 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 8 chunks +70 lines, -83 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 12 chunks +20 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbramley
Created Revert of [arm64][turbofan]: Handle any immediate shift.
5 years, 6 months ago (2015-06-11 14:46:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176393002/1
5 years, 6 months ago (2015-06-11 14:46:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 14:46:36 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 14:46:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14755c0a2d8342c50523a65707a5ab79fd778df5
Cr-Commit-Position: refs/heads/master@{#28944}

Powered by Google App Engine
This is Rietveld 408576698