Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 1176393002: Revert of [arm64][turbofan]: Handle any immediate shift. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm64/macro-assembler-arm64.h" 7 #include "src/arm64/macro-assembler-arm64.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 auto length = i.InputOperand32(2); \ 324 auto length = i.InputOperand32(2); \
325 auto value = i.InputRegister32(3); \ 325 auto value = i.InputRegister32(3); \
326 __ Cmp(offset, length); \ 326 __ Cmp(offset, length); \
327 Label done; \ 327 Label done; \
328 __ B(hs, &done); \ 328 __ B(hs, &done); \
329 __ asm_instr(value, MemOperand(buffer, offset, UXTW)); \ 329 __ asm_instr(value, MemOperand(buffer, offset, UXTW)); \
330 __ Bind(&done); \ 330 __ Bind(&done); \
331 } while (0) 331 } while (0)
332 332
333 333
334 #define ASSEMBLE_SHIFT(asm_instr, width) \ 334 #define ASSEMBLE_SHIFT(asm_instr, width) \
335 do { \ 335 do { \
336 if (instr->InputAt(1)->IsRegister()) { \ 336 if (instr->InputAt(1)->IsRegister()) { \
337 __ asm_instr(i.OutputRegister##width(), i.InputRegister##width(0), \ 337 __ asm_instr(i.OutputRegister##width(), i.InputRegister##width(0), \
338 i.InputRegister##width(1)); \ 338 i.InputRegister##width(1)); \
339 } else { \ 339 } else { \
340 uint32_t imm = \ 340 int imm = \
341 static_cast<uint32_t>(i.InputOperand##width(1).ImmediateValue()); \ 341 static_cast<int>(i.InputOperand##width(1).immediate().value()); \
342 __ asm_instr(i.OutputRegister##width(), i.InputRegister##width(0), \ 342 __ asm_instr(i.OutputRegister##width(), i.InputRegister##width(0), imm); \
343 imm % (width)); \ 343 } \
344 } \
345 } while (0) 344 } while (0)
346 345
347 346
348 void CodeGenerator::AssembleDeconstructActivationRecord() { 347 void CodeGenerator::AssembleDeconstructActivationRecord() {
349 CallDescriptor* descriptor = linkage()->GetIncomingDescriptor(); 348 CallDescriptor* descriptor = linkage()->GetIncomingDescriptor();
350 int stack_slots = frame()->GetSpillSlotCount(); 349 int stack_slots = frame()->GetSpillSlotCount();
351 if (descriptor->IsJSFunctionCall() || stack_slots > 0) { 350 if (descriptor->IsJSFunctionCall() || stack_slots > 0) {
352 __ Mov(jssp, fp); 351 __ Mov(jssp, fp);
353 __ Pop(fp, lr); 352 __ Pop(fp, lr);
354 int pop_count = descriptor->IsJSFunctionCall() 353 int pop_count = descriptor->IsJSFunctionCall()
(...skipping 975 matching lines...) Expand 10 before | Expand all | Expand 10 after
1330 } 1329 }
1331 } 1330 }
1332 MarkLazyDeoptSite(); 1331 MarkLazyDeoptSite();
1333 } 1332 }
1334 1333
1335 #undef __ 1334 #undef __
1336 1335
1337 } // namespace compiler 1336 } // namespace compiler
1338 } // namespace internal 1337 } // namespace internal
1339 } // namespace v8 1338 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698