Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1176243006: make gm background colors 565 compatible (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 6 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make gm background colors 565 compatible Change a batch of GM tests to convert their background color so that it is representable in 8888 and 565. Enable portable text in those same tests to minimize platform differences. In a couple of bitmap tests, use portable typefaces instead of choosing 'Times' which may or may not be available on the platform. R=borenet@google.com Committed: https://skia.googlesource.com/skia/+/be7f768a357aefb39c42d24b81b24d647bb6ab70

Patch Set 1 #

Patch Set 2 : revert bitmap test changes -- only need to change font #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -65 lines) Patch
M gm/anisotropic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/arcofzorro.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigblurs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigmatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapcopy.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/bitmapfilters.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/blurs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bmpfilterqualityrepeat.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M gm/clipdrawdraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colormatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/complexclip3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/constcolorprocessor.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M gm/dcshader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/downsamplebitmap.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M gm/drawlooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/emptypath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filltypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filterbitmap.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filterindiabox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradientDirtyLaundry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradient_matrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients_no_texture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/internal_links.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/modecolorfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/nested.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pathinterior.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/rrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/shadertext2.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/shadertext3.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/shadows.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/simpleaaclip.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/tinybitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176243006/1
5 years, 6 months ago (2015-06-15 11:31:12 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-15 11:31:13 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1534)
5 years, 6 months ago (2015-06-15 11:32:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176243006/20001
5 years, 6 months ago (2015-06-15 11:48:34 UTC) #7
borenet
LGTM. I assume this will trigger a lot of new images?
5 years, 6 months ago (2015-06-15 12:09:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/be7f768a357aefb39c42d24b81b24d647bb6ab70
5 years, 6 months ago (2015-06-15 12:10:05 UTC) #9
caryclark
5 years, 6 months ago (2015-06-15 12:21:37 UTC) #10
caryclark
5 years, 6 months ago (2015-06-15 12:27:35 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1184123002/ by caryclark@google.com.

The reason for reverting is: breaks many bots with refcnt error.

Powered by Google App Engine
This is Rietveld 408576698