src/IceInstMIPS32.def - Issue 1176133004: implement the null function for the Mips32 subzero compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstMIPS32.def

Issue 1176133004: implement the null function for the Mips32 subzero compiler (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixing patch per review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstMIPS32.def

diff --git a/src/IceInstMIPS32.def b/src/IceInstMIPS32.def

index 3b6f3870797dcd9c55ca78951ecc566285bdc692..351eccec30022492f3aae9c7c2258f92a4ff233a 100644

--- a/src/IceInstMIPS32.def

+++ b/src/IceInstMIPS32.def

@@ -15,7 +15,7 @@

#define SUBZERO_SRC_ICEINSTMIPS32_DEF

// NOTE: PC and SP are not considered isInt, to avoid register allocating.

-// TODO (reed kotler). This needs to be scrubbed and is a placeholder to get

+// TODO(reed kotler). This needs to be scrubbed and is a placeholder to get

// the Mips skeleton in.

#define REGMIPS32_GPR_TABLE \

« no previous file with comments | « src/IceInstMIPS32.cpp ('k') | src/IceTargetLoweringMIPS32.h » ('j') | tests_lit/llvm2ice_tests/function_aligned.ll » ('J')