Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1176133002: Add support for text styles - Work In Progress (Closed)

Created:
5 years, 6 months ago by hansmuller1
Modified:
5 years, 6 months ago
Reviewers:
Hixie, eseidel
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add support for text styles - Work In Progress Added a TextStyle class and a style: parameter in Text, Paragraph. The stock app uses it to make the Toolbar's title white. I haven't been able to finish converting the info in typography.dart to TextStyle objects. The final fields in _Black don't compile because the fontSize:,fontWeight: parameter values aren't const. Closes #213

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -43 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/rendering/paragraph.dart View 5 chunks +34 lines, -4 lines 4 comments Download
M sky/sdk/lib/framework/theme2/typography.dart View 2 chunks +36 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Hixie
This approach seems sound. https://codereview.chromium.org/1176133002/diff/1/sky/sdk/lib/framework/rendering/paragraph.dart File sky/sdk/lib/framework/rendering/paragraph.dart (right): https://codereview.chromium.org/1176133002/diff/1/sky/sdk/lib/framework/rendering/paragraph.dart#newcode15 sky/sdk/lib/framework/rendering/paragraph.dart:15: final Color color; constructor then ...
5 years, 6 months ago (2015-06-11 17:39:28 UTC) #2
eseidel
5 years, 6 months ago (2015-06-12 00:22:15 UTC) #4
Picked up this patch and finished it in
https://codereview.chromium.org/1178913003.

Powered by Google App Engine
This is Rietveld 408576698