Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1178913003: Add support for text styles. (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add support for text styles. This is a completion of Hans's WIP patch: https://codereview.chromium.org/1176133002/ Makes it possible for us to style text in fn2 apps. The title style in the toolbar doesn't look quite right but as far as I can tell its the same color as the old typography code produced. Will need further investigation. Fixes #213 R=abarth@chromium.org, jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/66b6706007ef9b4a3b1ae22d39cd6c49eb70c4ce

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add support for TextAlign #

Patch Set 3 : Updated per Hixie's reviews #

Patch Set 4 : Fix test per jackson's review #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -74 lines) Patch
M sky/engine/core/painting/LayoutRoot.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 2 chunks +9 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/rendering/paragraph.dart View 1 2 3 4 chunks +92 lines, -11 lines 3 comments Download
M sky/sdk/lib/framework/theme2/typography.dart View 1 2 1 chunk +41 lines, -44 lines 0 comments Download
M sky/sdk/lib/framework/widgets/ui_node.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/widgets/wrappers.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M sky/tests/framework/stocks-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
eseidel
5 years, 6 months ago (2015-06-12 00:21:56 UTC) #1
jackson
lgtm I think hixie had some comments on the original note that stocks test is ...
5 years, 6 months ago (2015-06-12 01:32:50 UTC) #3
eseidel
PTAL
5 years, 6 months ago (2015-06-12 01:36:28 UTC) #4
abarth-chromium
lgtm https://codereview.chromium.org/1178913003/diff/60001/sky/sdk/lib/framework/rendering/paragraph.dart File sky/sdk/lib/framework/rendering/paragraph.dart (right): https://codereview.chromium.org/1178913003/diff/60001/sky/sdk/lib/framework/rendering/paragraph.dart#newcode39 sky/sdk/lib/framework/rendering/paragraph.dart:39: TextStyle copyWith({ In BoxConstraints, we call a similar ...
5 years, 6 months ago (2015-06-12 03:11:17 UTC) #6
eseidel
5 years, 6 months ago (2015-06-12 19:29:44 UTC) #7
Message was sent while issue was closed.
Landed as 66b6706007ef9b4a3b1ae22d39cd6c49eb70c4ce

Powered by Google App Engine
This is Rietveld 408576698