Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1176113008: Stop using the NVPR glyph loading functionality (Closed)

Created:
5 years, 6 months ago by Kimmo Kinnunen
Modified:
5 years, 6 months ago
Reviewers:
bungeman-skia, bsalomon
CC:
reviews_skia.org, bungeman-skia, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@chromium-pathrendering-prepare-01-for-fragment-bind
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop using the NVPR glyph loading functionality Remove the NVPR glyph loading functionality. A bit risky feature. Committed: https://skia.googlesource.com/skia/+/591a2ca842cb34919695a32757d700dee8b7822c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -72 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPathRendering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 2 chunks +0 lines, -59 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kimmo Kinnunen
forgot to send this one for review
5 years, 6 months ago (2015-06-22 06:08:35 UTC) #2
bsalomon
lgtm (sorry for the delay, was OOO)
5 years, 6 months ago (2015-06-23 13:25:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176113008/1
5 years, 6 months ago (2015-06-23 14:14:40 UTC) #5
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-23 14:14:41 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 14:27:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/591a2ca842cb34919695a32757d700dee8b7822c

Powered by Google App Engine
This is Rietveld 408576698