Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 11761005: views: Target the synthetic wheel events to the view under the mouse cursor. (Closed)

Created:
7 years, 11 months ago by sadrul
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

views: Target the synthetic wheel events to the view under the mouse cursor. BUG=137591 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175526

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : aura-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -14 lines) Patch
M ui/views/controls/menu/menu_host_root_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 2 chunks +117 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
Hi! Does this look like a reasonable change to have in views? Or should this ...
7 years, 11 months ago (2013-01-02 22:47:44 UTC) #1
sky
This seems fine to me. How about test coverage?
7 years, 11 months ago (2013-01-07 17:44:16 UTC) #2
sadrul
On 2013/01/07 17:44:16, sky wrote: > This seems fine to me. How about test coverage? ...
7 years, 11 months ago (2013-01-07 19:39:53 UTC) #3
sky
7 years, 11 months ago (2013-01-07 22:03:50 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698