Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: Source/core/dom/Document.h

Issue 1176013002: Move attributes and methods from HTMLDocument to Document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved the order of open and close function Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index f38e4d3abcfe6fe70d2a00464e62b0aa09b4232d..0cbf18000ff66d949097ece43af9fd16f59cc0f3 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -490,11 +490,16 @@ public:
DocumentLoader* loader() const;
- void open(Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
+ // The open and close are used internally for dynamic insertion and does not handle exceptions.
philipj_slow 2015/06/29 15:02:38 Sorry for the churn, but I meant this order of thi
Habib Virji 2015/06/29 15:25:21 Sorry for not getting the order.. Updates now as s
+ void open();
+ void close();
+
+ // This open() is based on the DOM API document.open()
+ void open(Document* ownerDocument, ExceptionState&);
PassRefPtrWillBeRawPtr<DocumentParser> implicitOpen(ParserSynchronizationPolicy);
- // close() is the DOM API document.close()
- void close(ExceptionState& = ASSERT_NO_EXCEPTION);
+ // This close() is based on the DOM API document.close()
+ void close(ExceptionState&);
// In some situations (see the code), we ignore document.close().
// explicitClose() bypass these checks and actually tries to close the
// input stream.
@@ -518,6 +523,8 @@ public:
void write(const SegmentedString& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
void write(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
void writeln(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
+ void write(LocalDOMWindow*, const Vector<String>& text, ExceptionState& = ASSERT_NO_EXCEPTION);
philipj_slow 2015/06/29 15:02:38 I don't think these are ever called without the Ex
Habib Virji 2015/06/29 15:25:20 Done.
+ void writeln(LocalDOMWindow*, const Vector<String>& text, ExceptionState& = ASSERT_NO_EXCEPTION);
bool wellFormed() const { return m_wellFormed; }

Powered by Google App Engine
This is Rietveld 408576698