Move attributes and methods from HTMLDocument to Document

Source/core/dom/Document.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
@@ skipping 472 matching lines @@
     Document& axObjectCacheOwner() const;
     AXObjectCache* existingAXObjectCache() const;
     AXObjectCache* axObjectCache() const;
     void clearAXObjectCache();
 
     // to get visually ordered hebrew and arabic pages right
     bool visuallyOrdered() const { return m_visuallyOrdered; }
 
     DocumentLoader* loader() const;
 
-    void open(Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
+    // The open and close are used internally for dynamic insertion and does not handle exceptions.

[philipj_slow, 2015/06/29 15:02:38]

Sorry for the churn, but I meant this order of things, here and in
implementation:

// This is the DOM API document.open()
void open(Document* ownerDocument, ExceptionState&);
// This is used internally and does not handle exceptions.
void open();
PassRefPtrWillBeRawPtr<DocumentParser>
implicitOpen(ParserSynchronizationPolicy);

// This is the DOM API document.close()
void close(ExceptionState&);
// This is used internally and does not handle exceptions.
void close();
// In some situations ...

[Habib Virji, 2015/06/29 15:25:21]

Sorry for not getting the order.. Updates now as suggested.

+    void open();
+    void close();
+
+    // This open() is based on the DOM API document.open()
+    void open(Document* ownerDocument, ExceptionState&);
     PassRefPtrWillBeRawPtr<DocumentParser> implicitOpen(ParserSynchronizationPolicy);
 
-    // close() is the DOM API document.close()
-    void close(ExceptionState& = ASSERT_NO_EXCEPTION);
+    // This close() is based on the DOM API document.close()
+    void close(ExceptionState&);
     // In some situations (see the code), we ignore document.close().
     // explicitClose() bypass these checks and actually tries to close the
     // input stream.
     void explicitClose();
     // implicitClose() actually does the work of closing the input stream.
     void implicitClose();
 
     bool dispatchBeforeUnloadEvent(ChromeClient&, bool&);
     void dispatchUnloadEvents();
 
     enum PageDismissalType {
         NoDismissal = 0,
         BeforeUnloadDismissal = 1,
         PageHideDismissal = 2,
         UnloadDismissal = 3
     };
     PageDismissalType pageDismissalEventBeingDispatched() const;
 
     void cancelParsing();
 
     void write(const SegmentedString& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
     void write(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
     void writeln(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);
+    void write(LocalDOMWindow*, const Vector<String>& text, ExceptionState& = ASSERT_NO_EXCEPTION);

[philipj_slow, 2015/06/29 15:02:38]

I don't think these are ever called without the ExceptionState& argument, so can
the default be removed?

[Habib Virji, 2015/06/29 15:25:20]

Done.

+    void writeln(LocalDOMWindow*, const Vector<String>& text, ExceptionState& = ASSERT_NO_EXCEPTION);
 
     bool wellFormed() const { return m_wellFormed; }
 
     const KURL& url() const { return m_url; }
     void setURL(const KURL&);
 
     // To understand how these concepts relate to one another, please see the
     // comments surrounding their declaration.
     const KURL& baseURL() const { return m_baseURL; }
     void setBaseURLOverride(const KURL&);
@@ skipping 911 matching lines @@
 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 CORE_EXPORT void showLiveDocumentInstances();
 #endif
 
 #endif // Document_h