Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1175993005: DM testing for skipping and scaling (Closed)

Created:
5 years, 6 months ago by msarett
Modified:
5 years, 6 months ago
Reviewers:
scroggo, emmaleer
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM testing for skipping and scaling BUG=skia: Committed: https://skia.googlesource.com/skia/+/0a24297be4737f5fe23b3b918b193260e64ab32d

Patch Set 1 : #

Total comments: 10

Patch Set 2 : kStripe_Mode is a separate mode, scaling can be tested for all modes #

Total comments: 14

Patch Set 3 : Added error checking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -38 lines) Patch
M dm/DM.cpp View 1 2 1 chunk +48 lines, -32 lines 0 comments Download
M dm/DMSrcSink.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 2 6 chunks +92 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
msarett
Added kScale_Mode to CodecSrc in DM. Performing the decode in "stripes" allows me to test ...
5 years, 6 months ago (2015-06-10 20:41:20 UTC) #4
scroggo
On 2015/06/10 20:41:20, msarett wrote: > Added kScale_Mode to CodecSrc in DM. > > Performing ...
5 years, 6 months ago (2015-06-11 15:50:02 UTC) #5
msarett
I created kStripe_Mode as a separate mode and enabled scaling to be tested for all ...
5 years, 6 months ago (2015-06-11 19:29:36 UTC) #6
scroggo
lgtm https://codereview.chromium.org/1175993005/diff/60001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/1175993005/diff/60001/dm/DM.cpp#newcode225 dm/DM.cpp:225: push_src("image", "scale_kGray8", new CodecSrc(path, CodecSrc::kStripe_Mode, stripe_kGray8? https://codereview.chromium.org/1175993005/diff/60001/dm/DMSrcSink.cpp File ...
5 years, 6 months ago (2015-06-11 20:12:48 UTC) #7
msarett
https://codereview.chromium.org/1175993005/diff/60001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/1175993005/diff/60001/dm/DM.cpp#newcode225 dm/DM.cpp:225: push_src("image", "scale_kGray8", new CodecSrc(path, CodecSrc::kStripe_Mode, On 2015/06/11 20:12:48, scroggo ...
5 years, 6 months ago (2015-06-11 21:20:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175993005/80001
5 years, 6 months ago (2015-06-11 21:21:21 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 21:27:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://skia.googlesource.com/skia/+/0a24297be4737f5fe23b3b918b193260e64ab32d

Powered by Google App Engine
This is Rietveld 408576698