DM testing for skipping and scaling

dm/DMSrcSink.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "DMSrcSink.h"
 #include "SamplePipeControllers.h"
 #include "SkCodec.h"
@@ skipping 46 matching lines @@
     return gm->getName();
 }
 
 void GMSrc::modifyGrContextOptions(GrContextOptions* options) const {
     SkAutoTDelete<skiagm::GM> gm(fFactory(NULL));
     gm->modifyGrContextOptions(options);
 }
 
 /*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/
 
-CodecSrc::CodecSrc(Path path, Mode mode, DstColorType dstColorType)
+CodecSrc::CodecSrc(Path path, Mode mode, DstColorType dstColorType, float scale)
     : fPath(path)
     , fMode(mode)
     , fDstColorType(dstColorType)
+    , fScale(scale)
 {}
 
 Error CodecSrc::draw(SkCanvas* canvas) const {
     SkImageInfo canvasInfo;
     if (NULL == canvas->peekPixels(&canvasInfo, NULL)) {
         // TODO: Once we implement GPU paths (e.g. JPEG YUV), we should use a deferred decode to
         // let the GPU handle it.
         return Error::Nonfatal("No need to test decoding to non-raster backend.");
     }
 
@@ skipping 107 matching lines @@
             const int extraY = h % divisor;
             /*
             * if w or h are not evenly divided by divisor need to adjust width and height of end
             * subsets to cover entire image.
             * Add extraX and extraY to largestSubsetBm's width and height to adjust width
             * and height of end subsets.
             * subsetBm is extracted from largestSubsetBm.
             * subsetBm's size is determined based on the current subset and may be larger for end
             * subsets.
             */
-            SkImageInfo largestSubsetDecodeInfo = 
+            SkImageInfo largestSubsetDecodeInfo =
                     decodeInfo.makeWH(subsetWidth + extraX, subsetHeight + extraY);
             SkBitmap largestSubsetBm;
             if (!largestSubsetBm.tryAllocPixels(largestSubsetDecodeInfo, NULL, colorTable.get())) {
                 return SkStringPrintf("Image(%s) is too large (%d x %d)\n", fPath.c_str(),
                         largestSubsetDecodeInfo.width(), largestSubsetDecodeInfo.height());
             }
             char* line = SkNEW_ARRAY(char, decodeInfo.minRowBytes());
             SkAutoTDeleteArray<char> lineDeleter(line);
             for (int col = 0; col < divisor; col++) {
                 //currentSubsetWidth may be larger than subsetWidth for rightmost subsets
@@ skipping 10 matching lines @@
                             NULL, colorPtr, colorCountPtr);
                     if (NULL == subsetScanlineDecoder) {
                         if (x == 0 && y == 0) {
                             //first try, image may not be compatible
                             return Error::Nonfatal("Cannot use scanline decoder for all images");
                         } else {
                             return "Error scanline decoder is NULL";
                         }
                     }
                     //skip to first line of subset
-                    const SkImageGenerator::Result skipResult = 
+                    const SkImageGenerator::Result skipResult =
                             subsetScanlineDecoder->skipScanlines(y);
                     switch (skipResult) {
                         case SkImageGenerator::kSuccess:
                         case SkImageGenerator::kIncompleteInput:
                             break;
                         default:
                             return SkStringPrintf("%s failed after attempting to skip %d scanlines"
                                     "with error message %d", fPath.c_str(), y, (int) skipResult);
                     }
                     //create and set size of subsetBm
@@ skipping 15 matching lines @@
                             default:
                                 return SkStringPrintf("%s failed after %d scanlines with error" 
                                         "message %d", fPath.c_str(), y-1, (int) subsetResult);
                         }
                     }
                     canvas->drawBitmap(subsetBm, SkIntToScalar(x), SkIntToScalar(y));
                 }
             }
             break;
         }
+        // This mode tests scaling and skipping.  The decode is performed for the scaled image
+        // dimensions using stripes.

[scroggo, 2015/06/11 15:50:02]

It is curious to me that we combine scaling with stripes. Maybe stripes should
be a separate mode?

On a related note, I can imagine a couple of ways to do scaling:
- use the dimensions from getScaledDimensions
  - jpeg will support scaling (although maybe not to the exact dimensions we
want)
- others may not (e.g. png). we should have some sort of fallback (which can
also be used if jpeg is not exact)
  - I don't know whether the fallback should be a separate case or not.

[msarett, 2015/06/11 19:29:36]

Yes this was an odd decision that didn't make much sense.  This has been
redesigned.

+        case kScale_Mode: {
+            SkISize size = codec->getScaledDimensions(fScale);
+            SkImageInfo info = decodeInfo.makeWH(size.width(), size.height());
+            int width = info.width();
+            int height = info.height();
+            // This value is chosen arbitrarily.  We exercise more cases by choosing a value that
+            // does not align with image blocks.
+            const int stripeHeight = 37;
+            const int numStripes = (height + stripeHeight - 1) / stripeHeight;
+
+            // Create bitmap
+            SkBitmap bitmap;
+            if (!bitmap.tryAllocPixels(info, NULL, colorTable.get())) {
+                return SkStringPrintf("Cannot allocate pixels for %s %dx%d", fPath.c_str(),
+                        width, height);
+            }
+
+            // Decode odd stripes
+            SkScanlineDecoder* decoder = codec->getScanlineDecoder(info, NULL, colorPtr,
+                    colorCountPtr);
+            if (NULL == decoder) {
+                return Error::Nonfatal("Cannot use scanline decoder for all images");
+            }
+            for (int i = 0; i < numStripes; i += 2) {
+                // Skip a stripe
+                const int linesToSkip = SkTMin(stripeHeight, height - i * stripeHeight);
+                decoder->skipScanlines(linesToSkip);
+
+                // Read a stripe
+                const int startY = SkTMin((i + 1) * stripeHeight, height - 1);
+                const int linesToRead = SkTMax(0, SkTMin(stripeHeight, height - startY));
+                decoder->getScanlines(bitmap.getAddr(0, startY), linesToRead, bitmap.rowBytes());
+            }
+
+            // Decode even stripes
+            decoder = codec->getScanlineDecoder(info, NULL, colorPtr, colorCountPtr);
+            for (int i = 0; i < numStripes; i += 2) {
+                // Read a stripe
+                const int startY = i * stripeHeight;
+                const int linesToRead = SkTMin(stripeHeight, height - startY);
+                decoder->getScanlines(bitmap.getAddr(0, startY), linesToRead, bitmap.rowBytes());
+
+                // Skip a stripe
+                const int linesToSkip = SkTMax(0, SkTMin(stripeHeight,
+                        height - (i + 1) * stripeHeight));
+                decoder->skipScanlines(linesToSkip);
+            }
+            canvas->drawBitmap(bitmap, 0, 0);
+        }
     }
     return "";
 }
 
 SkISize CodecSrc::size() const {
     SkAutoTUnref<SkData> encoded(SkData::NewFromFileName(fPath.c_str()));
     SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(encoded));
     if (NULL != codec) {
-        return codec->getInfo().dimensions();
+        SkISize size = codec->getScaledDimensions(fScale);

[scroggo, 2015/06/11 15:50:02]

For png (for example) this will return the original size. Not sure this is
useful.

[msarett, 2015/06/11 19:29:36]

We are now returning Error::Nonfatal for tests where fScale is not 1.0 and the
scaled dims are not different from the original dims.  I hope that clears up
this concern.

+        return size;
     } else {
         return SkISize::Make(0, 0);
     }
 }
 
 Name CodecSrc::name() const {
-    return SkOSPath::Basename(fPath.c_str());
+    if (1.0f == fScale) {
+        return SkOSPath::Basename(fPath.c_str());
+    } else {
+        return SkStringPrintf("%s_%.3f", SkOSPath::Basename(fPath.c_str()).c_str(), fScale);
+    }
 }
 
 /*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/
 
 ImageSrc::ImageSrc(Path path, int divisor) : fPath(path), fDivisor(divisor) {}
 
 Error ImageSrc::draw(SkCanvas* canvas) const {
     SkImageInfo canvasInfo;
     if (NULL == canvas->peekPixels(&canvasInfo, NULL)) {
         // TODO: Instead, use lazy decoding to allow the GPU to handle cases like YUV.
@@ skipping 591 matching lines @@
             skr.visit<void>(i, drawsAsSingletonPictures);
         }
         SkAutoTUnref<SkPicture> macroPic(macroRec.endRecordingAsPicture());
 
         canvas->drawPicture(macroPic);
         return "";
     });
 }
 
 }  // namespace DM