Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1175963002: Make writing of frame translation platform independent. (Closed)

Created:
5 years, 6 months ago by Jarin
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make writing of frame translation platform independent. BUG= R=bmeurer@chromium.org Committed: https://crrev.com/1c5d4d7eda4a0e7c8c907df461a26f28f5d92a4e Cr-Commit-Position: refs/heads/master@{#28923}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -680 lines) Patch
M src/arm/lithium-codegen-arm.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +1 line, -87 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +1 line, -87 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +1 line, -87 lines 0 comments Download
M src/lithium-codegen.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/lithium-codegen.cc View 3 chunks +96 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +1 line, -87 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +1 line, -87 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 2 chunks +1 line, -87 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +1 line, -87 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +1 line, -43 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Jarin
lgty?
5 years, 6 months ago (2015-06-10 12:19:47 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-11 04:21:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175963002/1
5 years, 6 months ago (2015-06-11 04:21:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3311)
5 years, 6 months ago (2015-06-11 04:23:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175963002/20001
5 years, 6 months ago (2015-06-11 04:34:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/4650)
5 years, 6 months ago (2015-06-11 04:48:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175963002/20001
5 years, 6 months ago (2015-06-11 05:59:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 06:09:18 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 06:09:24 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c5d4d7eda4a0e7c8c907df461a26f28f5d92a4e
Cr-Commit-Position: refs/heads/master@{#28923}

Powered by Google App Engine
This is Rietveld 408576698