Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1175963002: Make writing of frame translation platform independent. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/lithium-codegen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/lithium-codegen-ia32.cc
diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc
index 3e5a2fe021b6294aad403d24497f88712f71c5ea..ba601db35dd22f033c7737d4276abdac5478dec2 100644
--- a/src/ia32/lithium-codegen-ia32.cc
+++ b/src/ia32/lithium-codegen-ia32.cc
@@ -618,85 +618,9 @@ void LCodeGen::WriteTranslation(LEnvironment* environment,
// The translation includes one command per value in the environment.
int translation_size = environment->translation_size();
- // The output frame height does not include the parameters.
- int height = translation_size - environment->parameter_count();
WriteTranslation(environment->outer(), translation);
-
- switch (environment->frame_type()) {
- case JS_FUNCTION: {
- int shared_id = DefineDeoptimizationLiteral(
- environment->entry() ? environment->entry()->shared()
- : info()->shared_info());
- translation->BeginJSFrame(environment->ast_id(), shared_id, height);
- if (info()->closure().is_identical_to(environment->closure())) {
- translation->StoreJSFrameFunction();
- } else {
- int closure_id = DefineDeoptimizationLiteral(environment->closure());
- translation->StoreLiteral(closure_id);
- }
- break;
- }
- case JS_CONSTRUCT: {
- int shared_id = DefineDeoptimizationLiteral(
- environment->entry() ? environment->entry()->shared()
- : info()->shared_info());
- translation->BeginConstructStubFrame(shared_id, translation_size);
- if (info()->closure().is_identical_to(environment->closure())) {
- translation->StoreJSFrameFunction();
- } else {
- int closure_id = DefineDeoptimizationLiteral(environment->closure());
- translation->StoreLiteral(closure_id);
- }
- break;
- }
- case JS_GETTER: {
- DCHECK(translation_size == 1);
- DCHECK(height == 0);
- int shared_id = DefineDeoptimizationLiteral(
- environment->entry() ? environment->entry()->shared()
- : info()->shared_info());
- translation->BeginGetterStubFrame(shared_id);
- if (info()->closure().is_identical_to(environment->closure())) {
- translation->StoreJSFrameFunction();
- } else {
- int closure_id = DefineDeoptimizationLiteral(environment->closure());
- translation->StoreLiteral(closure_id);
- }
- break;
- }
- case JS_SETTER: {
- DCHECK(translation_size == 2);
- DCHECK(height == 0);
- int shared_id = DefineDeoptimizationLiteral(
- environment->entry() ? environment->entry()->shared()
- : info()->shared_info());
- translation->BeginSetterStubFrame(shared_id);
- if (info()->closure().is_identical_to(environment->closure())) {
- translation->StoreJSFrameFunction();
- } else {
- int closure_id = DefineDeoptimizationLiteral(environment->closure());
- translation->StoreLiteral(closure_id);
- }
- break;
- }
- case ARGUMENTS_ADAPTOR: {
- int shared_id = DefineDeoptimizationLiteral(
- environment->entry() ? environment->entry()->shared()
- : info()->shared_info());
- translation->BeginArgumentsAdaptorFrame(shared_id, translation_size);
- if (info()->closure().is_identical_to(environment->closure())) {
- translation->StoreJSFrameFunction();
- } else {
- int closure_id = DefineDeoptimizationLiteral(environment->closure());
- translation->StoreLiteral(closure_id);
- }
- break;
- }
- case STUB:
- translation->BeginCompiledStubFrame(translation_size);
- break;
- }
+ WriteTranslationFrame(environment, translation);
int object_index = 0;
int dematerialized_index = 0;
@@ -1006,16 +930,6 @@ void LCodeGen::PopulateDeoptimizationData(Handle<Code> code) {
}
-int LCodeGen::DefineDeoptimizationLiteral(Handle<Object> literal) {
- int result = deoptimization_literals_.length();
- for (int i = 0; i < deoptimization_literals_.length(); ++i) {
- if (deoptimization_literals_[i].is_identical_to(literal)) return i;
- }
- deoptimization_literals_.Add(literal, zone());
- return result;
-}
-
-
void LCodeGen::PopulateDeoptimizationLiteralsWithInlinedFunctions() {
DCHECK_EQ(0, deoptimization_literals_.length());
for (auto function : chunk()->inlined_functions()) {
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/lithium-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698