Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 1175823002: ServiceWorker: Implement ServiceWorkerRegistration.update() (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index e68f64451ba918e53105238a7f6daec12016fdd6..645d23bada0bc291fb54efde790aea91407d40f1 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -126,6 +126,15 @@ void ServiceWorkerDispatcher::RegisterServiceWorker(
CurrentWorkerId(), request_id, provider_id, pattern, script_url));
}
+void ServiceWorkerDispatcher::UpdateServiceWorker(
+ int provider_id,
+ const GURL& pattern) {
kinuko 2015/06/10 06:47:17 I'm curious why we supply pattern / scopeURL in th
nhiroki 2015/06/10 06:55:26 It's used for finding a registration. Is there any
+ if (pattern.possibly_invalid_spec().size() > GetMaxURLChars())
+ return;
falken 2015/06/10 04:04:40 Hmm, should/can we surface this error somehow? Lik
nhiroki 2015/06/10 06:36:32 I'm not really sure how to print this and other er
+ thread_safe_sender_->Send(new ServiceWorkerHostMsg_UpdateServiceWorker(
+ provider_id, pattern));
+}
+
void ServiceWorkerDispatcher::UnregisterServiceWorker(
int provider_id,
const GURL& pattern,

Powered by Google App Engine
This is Rietveld 408576698