ServiceWorker: Implement ServiceWorkerRegistration.update() (2)

content/child/service_worker/service_worker_dispatcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/service_worker/service_worker_dispatcher.h"
 
 #include "base/lazy_instance.h"
 #include "base/stl_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/thread_local.h"
@@ skipping 108 matching lines @@
   int request_id = pending_registration_callbacks_.Add(callbacks);
   TRACE_EVENT_ASYNC_BEGIN2("ServiceWorker",
                            "ServiceWorkerDispatcher::RegisterServiceWorker",
                            request_id,
                            "Scope", pattern.spec(),
                            "Script URL", script_url.spec());
   thread_safe_sender_->Send(new ServiceWorkerHostMsg_RegisterServiceWorker(
       CurrentWorkerId(), request_id, provider_id, pattern, script_url));
 }
 
+void ServiceWorkerDispatcher::UpdateServiceWorker(
+    int provider_id,
+    const GURL& pattern) {

[kinuko, 2015/06/10 06:47:17]

I'm curious why we supply pattern / scopeURL in the renderer process?

[nhiroki, 2015/06/10 06:55:26]

It's used for finding a registration. Is there any alternative to retrieve it?

+  if (pattern.possibly_invalid_spec().size() > GetMaxURLChars())
+    return;

[falken, 2015/06/10 04:04:40]

Hmm, should/can we surface this error somehow? Like as a console error?

[nhiroki, 2015/06/10 06:36:32]

I'm not really sure how to print this and other errors emitted in the
browser-side in the console, so let me leave a TODO comment for now.

+  thread_safe_sender_->Send(new ServiceWorkerHostMsg_UpdateServiceWorker(
+      provider_id, pattern));
+}
+
 void ServiceWorkerDispatcher::UnregisterServiceWorker(
     int provider_id,
     const GURL& pattern,
     WebServiceWorkerUnregistrationCallbacks* callbacks) {
   DCHECK(callbacks);
 
   if (pattern.possibly_invalid_spec().size() > GetMaxURLChars()) {
     scoped_ptr<WebServiceWorkerUnregistrationCallbacks>
         owned_callbacks(callbacks);
     std::string error_message(kServiceWorkerUnregisterErrorPrefix);
@@ skipping 549 matching lines @@
   bool adopt_handle = true;
   WebServiceWorkerRegistrationImpl* registration =
       CreateServiceWorkerRegistration(info, adopt_handle);
   registration->SetInstalling(GetServiceWorker(attrs.installing, adopt_handle));
   registration->SetWaiting(GetServiceWorker(attrs.waiting, adopt_handle));
   registration->SetActive(GetServiceWorker(attrs.active, adopt_handle));
   return registration;
 }
 
 }  // namespace content