Issue 1175753003: Kill onDidMount()/onDidUnmount() in favour of just overriding the relevant methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1175753003: Kill onDidMount()/onDidUnmount() in favour of just overriding the relevant methods. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Kill onDidMount()/onDidUnmount() in favour of just overriding the relevant methods. In general, we are hugely inconsistent in what onFoo/onFoo() means. I'm cleaning out all the cases where onFoo() is a method. Also, this fixes EditableText, which got missed in the recent syncFields() pass. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4adc8fb176a9ba7c73edaf25fa6abcfd145f761d

Patch Set 1 #

Patch Set 2 : git pull #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -63 lines)			Patch
M	sky/sdk/lib/framework/components2/animated_component.dart	View	1 2	1 chunk	+28 lines, -11 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/input.dart	View	1 2 3	3 chunks	+10 lines, -7 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/popup_menu.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/scrollable.dart	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/framework/editing2/editable_text.dart	View	1 2	3 chunks	+15 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View		3 chunks	+6 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1175753003/diff/20001/sky/sdk/lib/framework/editing2/editable_text.dart File sky/sdk/lib/framework/editing2/editable_text.dart (right): https://codereview.chromium.org/1175753003/diff/20001/sky/sdk/lib/framework/editing2/editable_text.dart#newcode52 sky/sdk/lib/framework/editing2/editable_text.dart:52: } super.didUnmount()

5 years, 6 months ago (2015-06-10 20:27:17 UTC) #2

Hixie

5 years, 6 months ago (2015-06-10 20:30:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
4adc8fb176a9ba7c73edaf25fa6abcfd145f761d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages