Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: sky/sdk/lib/framework/components2/popup_menu.dart

Issue 1175753003: Kill onDidMount()/onDidUnmount() in favour of just overriding the relevant methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/components2/input.dart ('k') | sky/sdk/lib/framework/components2/scrollable.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/popup_menu.dart
diff --git a/sky/sdk/lib/framework/components2/popup_menu.dart b/sky/sdk/lib/framework/components2/popup_menu.dart
index e11a528e2f1d50771657c7af6aefa15d57b3fa8c..11cb2979b41aa65f24a2e7602302dd6d91daf3a9 100644
--- a/sky/sdk/lib/framework/components2/popup_menu.dart
+++ b/sky/sdk/lib/framework/components2/popup_menu.dart
@@ -57,7 +57,6 @@ class PopupMenu extends AnimatedComponent {
animate(controller.position, (double value) {
_position = value;
});
- // onDidMount(_measureSize);
}
PopupMenuController controller;
@@ -94,6 +93,11 @@ class PopupMenu extends AnimatedComponent {
// height: ${math.min(_height, _height * _position * 1.5)}px;''';
// }
+ // void didMount() {
+ // _measureSize();
+ // super.didMount();
+ // }
+
// void _measureSize() {
// setState(() {
// var root = getRoot();
« no previous file with comments | « sky/sdk/lib/framework/components2/input.dart ('k') | sky/sdk/lib/framework/components2/scrollable.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698