Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: Source/modules/accessibility/AXSpinButton.h

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXSlider.cpp ('k') | Source/modules/accessibility/AXSpinButton.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXSpinButton.h
diff --git a/Source/modules/accessibility/AXSpinButton.h b/Source/modules/accessibility/AXSpinButton.h
index ce0a53694a7ef5115ffdc6bab5e848c76a7512bd..554ae7223ecf3018d3b81248d3642a4b75b0d7ea 100644
--- a/Source/modules/accessibility/AXSpinButton.h
+++ b/Source/modules/accessibility/AXSpinButton.h
@@ -36,14 +36,14 @@ class AXObjectCacheImpl;
class AXSpinButton final : public AXMockObject {
public:
- static PassRefPtr<AXSpinButton> create(AXObjectCacheImpl*);
+ static PassRefPtr<AXSpinButton> create(AXObjectCacheImpl&);
virtual ~AXSpinButton();
void setSpinButtonElement(SpinButtonElement* spinButton) { m_spinButtonElement = spinButton; }
void step(int amount);
private:
- explicit AXSpinButton(AXObjectCacheImpl*);
+ explicit AXSpinButton(AXObjectCacheImpl&);
virtual AccessibilityRole roleValue() const override;
virtual bool isSpinButton() const override { return true; }
@@ -58,14 +58,14 @@ private:
class AXSpinButtonPart final : public AXMockObject {
public:
- static PassRefPtr<AXSpinButtonPart> create(AXObjectCacheImpl*);
+ static PassRefPtr<AXSpinButtonPart> create(AXObjectCacheImpl&);
virtual ~AXSpinButtonPart() { }
bool isIncrementor() const { return m_isIncrementor; }
void setIsIncrementor(bool value) { m_isIncrementor = value; }
private:
- explicit AXSpinButtonPart(AXObjectCacheImpl*);
+ explicit AXSpinButtonPart(AXObjectCacheImpl&);
bool m_isIncrementor : 1;
virtual bool press() const override;
« no previous file with comments | « Source/modules/accessibility/AXSlider.cpp ('k') | Source/modules/accessibility/AXSpinButton.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698